Let selection events bypass ContentViewCore

content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
 import android.content.ClipboardManager;
@@ skipping 10 matching lines @@
 import android.view.Menu;
 import android.view.MenuInflater;
 import android.view.MenuItem;
 import android.view.View;
 import android.view.ViewConfiguration;
 import android.view.WindowManager;
 
 import org.chromium.base.BuildInfo;
 import org.chromium.base.Log;
 import org.chromium.base.VisibleForTesting;
+import org.chromium.base.annotations.CalledByNative;
+import org.chromium.base.annotations.JNINamespace;
 import org.chromium.base.metrics.RecordUserAction;
 import org.chromium.content.R;
 import org.chromium.content.browser.input.FloatingPastePopupMenu;
 import org.chromium.content.browser.input.LGEmailActionModeWorkaround;
 import org.chromium.content.browser.input.LegacyPastePopupMenu;
 import org.chromium.content.browser.input.PastePopupMenu;
 import org.chromium.content.browser.input.PastePopupMenu.PastePopupMenuDelegate;
 import org.chromium.content_public.browser.ActionModeCallbackHelper;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.ui.base.DeviceFormFactor;
 import org.chromium.ui.base.WindowAndroid;
 import org.chromium.ui.touch_selection.SelectionEventType;
 
 import java.util.List;
 
 /**
  * A class that handles input-related web content selection UI like action mode
  * and paste popup view. It wraps an {@link ActionMode} created by the associated view,
  * providing modified interaction with it.
  *
  * Embedders can use {@link ActionModeCallbackHelper} implemented by this class
  * to create {@link ActionMode.Callback} instance and configure the selection action
  * mode tasks to their requirements.
  */
+@JNINamespace("content")
 @TargetApi(Build.VERSION_CODES.M)
 public class SelectionPopupController extends ActionModeCallbackHelper {
     private static final String TAG = "SelectionPopupCtlr"; // 20 char limit
 
     /**
      * Android Intent size limitations prevent sending over a megabyte of data. Limit
      * query lengths to 100kB because other things may be added to the Intent.
      */
     private static final int MAX_SHARE_QUERY_LENGTH = 100000;
 
@@ skipping 59 matching lines @@
     // ContextSelectionProvider was able to classify it, otherwise null.
     private ContextSelectionProvider.Result mClassificationResult;
 
     // The resource ID for Assist menu item.
     private int mAssistMenuItemId;
 
     // This variable is set to true when showActionMode() is postponed till classification result
     // arrives or till the selection is adjusted based on the classification result.
     private boolean mPendingShowActionMode;
 
+    // Whether a scroll is in progress.
+    private boolean mScrollInProgress;
+
     /**
      * Create {@link SelectionPopupController} instance.
      * @param context Context for action mode.
      * @param window WindowAndroid instance.
      * @param webContents WebContents instance.
      * @param view Container view.
      * @param renderCoordinates Coordinates info used to position elements.
      */
     public SelectionPopupController(Context context, WindowAndroid window, WebContents webContents,
             View view, RenderCoordinates renderCoordinates) {
@@ skipping 18 matching lines @@
 
         mSelectionClient =
                 ContextSelectionClient.create(new ContextSelectionCallback(), window, webContents);
 
         // TODO(timav): Use android.R.id.textAssist for the Assist item id once we switch to
         // Android O SDK and remove |mAssistMenuItemId|.
         if (BuildInfo.isAtLeastO()) {
             mAssistMenuItemId =
                     mContext.getResources().getIdentifier("textAssist", "id", "android");
         }
+
+        nativeInit(webContents);
     }
 
     /**
      * Update the container view.
      */
     void setContainerView(View view) {
         assert view != null;
 
         // Cleans up action mode before switching to a new container view.
         if (isActionModeValid()) finishActionMode();
@@ skipping 171 matching lines @@
 
     /**
      * @see ActionMode#onWindowFocusChanged()
      */
     void onWindowFocusChanged(boolean hasWindowFocus) {
         if (supportsFloatingActionMode() && isActionModeValid()) {
             mActionMode.onWindowFocusChanged(hasWindowFocus);
         }
     }
 
+    void setScrollInProgress(boolean inProgress) {
+        mScrollInProgress = inProgress;
+    }
+
     /**
      * Hide or reveal the ActionMode. Note that this only has visible
      * side-effects if the underlying ActionMode supports hiding.
      * @param hide whether to hide or show the ActionMode.
      */
     void hideActionMode(boolean hide) {

[boliu, 2017/04/20 23:16:49]

hmm, did we use to unhide the action mode when touch scroll is over, but fling
is still happening? that just seems wrong. probably should just hide for both,
and show when neither type of scroll is happening

then don't need to expose this

[Jinsuk Kim, 2017/04/20 23:49:06]

Done.

         if (!canHideActionMode()) return;
         if (mHidden == hide) return;
         mHidden = hide;
         if (mHidden) {
             mRepeatingHideRunnable.run();
         } else {
             mView.removeCallbacks(mRepeatingHideRunnable);
             // To show the action mode that is being hidden call hide() again with a short delay.
             hideActionModeTemporarily(SHOW_DELAY_MS);
         }
@@ skipping 446 matching lines @@
         }
     }
 
     void restoreSelectionPopupsIfNecessary() {
         if (mHasSelection && !isActionModeValid()) {
             showActionModeOrClearOnFailure();
         }
     }
 
     // All coordinates are in DIP.
-    void onSelectionEvent(int eventType, int xAnchor, int yAnchor,
-            int left, int top, int right, int bottom, boolean isScrollInProgress,
-            boolean touchScrollInProgress) {
+    @CalledByNative
+    private void onSelectionEvent(
+            int eventType, int xAnchor, int yAnchor, int left, int top, int right, int bottom) {
         // Ensure the provided selection coordinates form a non-empty rect, as required by
         // the selection action mode.
         if (left == right) ++right;
         if (top == bottom) ++bottom;
         switch (eventType) {
             case SelectionEventType.SELECTION_HANDLES_SHOWN:
                 mSelectionRect.set(left, top, right, bottom);
                 mHasSelection = true;
                 mUnselectAllOnDismiss = true;
                 if (mSelectionClient == null || !mSelectionClient.sendsSelectionPopupUpdates()) {
@@ skipping 33 matching lines @@
                 // request always calling onClassified() callback.
                 break;
 
             case SelectionEventType.INSERTION_HANDLE_SHOWN:
                 mSelectionRect.set(left, top, right, bottom);
                 mIsInsertion = true;
                 break;
 
             case SelectionEventType.INSERTION_HANDLE_MOVED:
                 mSelectionRect.set(left, top, right, bottom);
-                if (!isScrollInProgress && isPastePopupShowing()) {
+                if (!mScrollInProgress && isPastePopupShowing()) {
                     showPastePopup(xAnchor, yAnchor);
                 } else {
                     destroyPastePopup();
                 }
                 break;
 
             case SelectionEventType.INSERTION_HANDLE_TAPPED:
                 if (mWasPastePopupShowingOnInsertionDragStart) {
                     destroyPastePopup();
                 } else {
@@ skipping 35 matching lines @@
     /**
      * Clears the current text selection. Note that we will try to move cursor to selection
      * end if applicable.
      */
     void clearSelection() {
         if (mWebContents == null || !isActionModeSupported()) return;
         mWebContents.collapseSelection();
         mClassificationResult = null;
     }
 
-    void onSelectionChanged(String text) {
+    @CalledByNative
+    private void onSelectionChanged(String text) {
         mLastSelectedText = text;
         if (mSelectionClient != null) {
             mSelectionClient.onSelectionChanged(text);
         }
     }
 
     // The client that implements selection augmenting functionality, or null if none exists.
     void setSelectionClient(SelectionClient selectionClient) {
         mSelectionClient = selectionClient;
 
@@ skipping 77 matching lines @@
                 mWebContents.adjustSelectionByCharacterOffset(result.startAdjust, result.endAdjust);
 
                 // Remain pending until SELECTION_HANDLES_MOVED arrives.
                 if (mPendingShowActionMode) return;
             }
 
             // Rely on this method to clear |mHidden| and unhide the action mode.
             showActionModeOrClearOnFailure();
         }
     };
+
+    private native void nativeInit(WebContents webContents);
 }