Source/core/animation/DocumentTimeline.cpp - Issue 28263002: Plumb timeToNextEffect through players and animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/DocumentTimeline.cpp

Issue 28263002: Plumb timeToNextEffect through players and animation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/DocumentTimeline.cpp

diff --git a/Source/core/animation/DocumentTimeline.cpp b/Source/core/animation/DocumentTimeline.cpp

index 6d70413a71a0f92f4ac912b43b55293844afe084..f47cbbdd824352f79a568b4fa99f888d1eb1145d 100644

--- a/Source/core/animation/DocumentTimeline.cpp

+++ b/Source/core/animation/DocumentTimeline.cpp

@@ -74,8 +74,9 @@ void DocumentTimeline::serviceAnimations(double monotonicAnimationStartTime)

m_currentTime = monotonicAnimationStartTime - m_zeroTimeAsPerfTime;

}

+ double timeToNextEffect = -1;

for (int i = m_players.size() - 1; i >= 0; --i) {

- if (!m_players[i]->update())

+ if (!m_players[i]->update(timeToNextEffect))

Timothy Loh 2013/10/18 06:01:27 Won't this only keep the last value?

shans 2013/10/21 00:37:57 Yeah. This point is where the next patch would kic

m_players.remove(i);

}

« no previous file with comments | « Source/core/animation/Animation.cpp ('k') | Source/core/animation/InertAnimation.h » ('j') | Source/core/animation/Player.h » ('J')