Plumb timeToNextEffect through players and animation

Source/core/animation/Player.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 27 matching lines @@
 
 class DocumentTimeline;
 
 class Player FINAL : public RefCounted<Player> {
 
 public:
     ~Player();
     static PassRefPtr<Player> create(DocumentTimeline*, TimedItem*);
 
     // Returns whether this player is still current or in effect.
-    bool update();
+    // timeToEffectChange returns:
+    //  -1  - if this player is no longer in effect

[Timothy Loh, 2013/10/18 06:01:27]

Maybe change -1 to std::numeric_limits<double>::infinity() so you can use min to
reduce multiple values? It's also more semantically meaningful.

[shans, 2013/10/21 00:37:57]

Done.

+    //  0   - if this player requires an update on the next frame
+    //  n   - if this player requires an update after 'n' units of time
+    bool update(double& timeToEffectChange);
+
+    inline bool update()

[Timothy Loh, 2013/10/18 06:01:27]

Do we need to keep this version around?

[shans, 2013/10/21 00:37:57]

Yeah. There are a few places where we simply don't care about the result of
timeToEffectChange. It's not cool to put the onus of creating a throwaway
variable on the caller in these cases.

+    {
+        double tmp;

[Timothy Loh, 2013/10/18 06:01:27]

We don't use these sorts of abbreviated variable names. Maybe 'placeholder', but
someone else can probably come up with a better name here.

[shans, 2013/10/21 00:37:57]

Changed to 'unused'

+        return update(tmp);
+    }
+
     void cancel();
     double currentTime() const;
     void setCurrentTime(double);
     bool paused() const { return !isNull(m_pauseStartTime); }
     void setPaused(bool);
     double playbackRate() const { return m_playbackRate; }
     void setPlaybackRate(double);
     double startTime() const { return m_startTime; }
     double timeDrift() const;
     DocumentTimeline* timeline() { return m_timeline; }
@@ skipping 10 matching lines @@
     double m_timeDrift;
     const double m_startTime;
 
     RefPtr<TimedItem> m_content;
     DocumentTimeline* const m_timeline;
 };
 
 } // namespace
 
 #endif