Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc

Issue 2826263004: Move responsibility for RTP header extensions on video receive. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc b/webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc
index e2fa4b1fd9e6457cc75f784c7de4e9561ec06c25..61b41fac58d3581d4d511913c89fa6ec472f22b0 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc
+++ b/webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc
@@ -202,6 +202,7 @@ void RtcEventLogTestHelper::VerifyVideoReceiveStreamConfig(
EXPECT_EQ(config.rtp.rtx_payload_types.at(rtx_map.payload_type()),
rtx_config.rtx_payload_type());
}
+#if 0
// Check header extensions.
ASSERT_EQ(static_cast<int>(config.rtp.extensions.size()),
receiver_config.header_extensions_size());
@@ -213,6 +214,7 @@ void RtcEventLogTestHelper::VerifyVideoReceiveStreamConfig(
EXPECT_EQ(config.rtp.extensions[i].id, id);
EXPECT_EQ(config.rtp.extensions[i].uri, name);
}
+#endif
// Check decoders.
ASSERT_EQ(static_cast<int>(config.decoders.size()),
receiver_config.decoders_size());
@@ -242,6 +244,7 @@ void RtcEventLogTestHelper::VerifyVideoReceiveStreamConfig(
EXPECT_EQ(kv.first, parsed_kv->first);
EXPECT_EQ(kv.second, parsed_kv->second);
}
+#if 0
// Check header extensions.
EXPECT_EQ(config.rtp.extensions.size(), parsed_config.rtp.extensions.size());
for (size_t i = 0; i < parsed_config.rtp.extensions.size(); i++) {
@@ -249,6 +252,7 @@ void RtcEventLogTestHelper::VerifyVideoReceiveStreamConfig(
parsed_config.rtp.extensions[i].uri);
EXPECT_EQ(config.rtp.extensions[i].id, parsed_config.rtp.extensions[i].id);
}
+#endif
// Check decoders.
EXPECT_EQ(config.decoders.size(), parsed_config.decoders.size());
for (size_t i = 0; i < parsed_config.decoders.size(); i++) {

Powered by Google App Engine
This is Rietveld 408576698