Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: webrtc/pc/mediacontroller.h

Issue 2826263004: Move responsibility for RTP header extensions on video receive. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_PC_MEDIACONTROLLER_H_ 11 #ifndef WEBRTC_PC_MEDIACONTROLLER_H_
12 #define WEBRTC_PC_MEDIACONTROLLER_H_ 12 #define WEBRTC_PC_MEDIACONTROLLER_H_
13 13
14 #include "webrtc/base/thread.h" 14 #include "webrtc/base/thread.h"
15 #include "webrtc/config.h"
15 16
16 namespace cricket { 17 namespace cricket {
17 class ChannelManager; 18 class ChannelManager;
18 struct MediaConfig; 19 struct MediaConfig;
19 } // namespace cricket 20 } // namespace cricket
20 21
21 namespace webrtc { 22 namespace webrtc {
22 class Call; 23 class Call;
23 class VoiceEngine; 24 class VoiceEngine;
24 class RtcEventLog; 25 class RtcEventLog;
25 26
26 // The MediaController currently owns shared state between media channels. 27 // The MediaController currently owns shared state between media channels.
27 // Abstract interface is defined here such that it can be faked/mocked for 28 // Abstract interface is defined here such that it can be faked/mocked for
28 // tests, but no other real reason. 29 // tests, but no other real reason.
29 class MediaControllerInterface { 30 class MediaControllerInterface {
30 public: 31 public:
31 // Will never return nullptr. 32 // Will never return nullptr.
32 static MediaControllerInterface* Create( 33 static MediaControllerInterface* Create(
33 const cricket::MediaConfig& config, 34 const cricket::MediaConfig& config,
34 rtc::Thread* worker_thread, 35 rtc::Thread* worker_thread,
35 cricket::ChannelManager* channel_manager, 36 cricket::ChannelManager* channel_manager,
36 webrtc::RtcEventLog* event_log); 37 webrtc::RtcEventLog* event_log);
37 38
38 virtual ~MediaControllerInterface() {} 39 virtual ~MediaControllerInterface() {}
39 virtual void Close() = 0; 40 virtual void Close() = 0;
40 virtual webrtc::Call* call_w() = 0; 41 virtual webrtc::Call* call_w() = 0;
41 virtual cricket::ChannelManager* channel_manager() const = 0; 42 virtual cricket::ChannelManager* channel_manager() const = 0;
42 virtual const cricket::MediaConfig& config() const = 0; 43 virtual const cricket::MediaConfig& config() const = 0;
44 // Proxy for Call (extensions may change mid-call).
45 // TODO(nisse): Should belong to RtpTransportController.
46 virtual void SetVideoReceiveRtpHeaderExtensions(
47 const std::vector<RtpExtension>& extensions) = 0;
pthatcher1 2017/04/29 00:25:18 This shouldn't be at the per-MediaController level
43 }; 48 };
44 } // namespace webrtc 49 } // namespace webrtc
45 50
46 #endif // WEBRTC_PC_MEDIACONTROLLER_H_ 51 #endif // WEBRTC_PC_MEDIACONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698