Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 2826243002: Add FileSystemState.knownFilesSetChanges stream. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 5 chunks +61 lines, -0 lines 2 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 8 months ago (2017-04-19 19:47:11 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2826243002/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right): https://codereview.chromium.org/2826243002/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart#newcode832 pkg/analyzer/lib/src/dart/analysis/file_state.dart:832: .add(new KnownFilesSetChange(addedFiles, removedFiles)); Do we want to only ...
3 years, 8 months ago (2017-04-19 20:09:52 UTC) #2
scheglov
https://codereview.chromium.org/2826243002/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart File pkg/analyzer/lib/src/dart/analysis/file_state.dart (right): https://codereview.chromium.org/2826243002/diff/1/pkg/analyzer/lib/src/dart/analysis/file_state.dart#newcode832 pkg/analyzer/lib/src/dart/analysis/file_state.dart:832: .add(new KnownFilesSetChange(addedFiles, removedFiles)); On 2017/04/19 20:09:52, Brian Wilkerson wrote: ...
3 years, 8 months ago (2017-04-19 20:21:47 UTC) #3
scheglov
3 years, 8 months ago (2017-04-19 20:23:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7faf4bac9373f8128d29df9f58450825cebc03d4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698