[subresource_filter] Mac UI updated and xib replaced with code based layout.

chrome/browser/ui/cocoa/subresource_filter/subresource_filter_bubble_controller.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_SUBRESOURCE_FILTER_SUBRESOURCE_FILTER_BUBBLE_CONTROLLER_H_
+#define CHROME_BROWSER_UI_COCOA_SUBRESOURCE_FILTER_SUBRESOURCE_FILTER_BUBBLE_CONTROLLER_H_
+
+#import <Cocoa/Cocoa.h>

[Robert Sesek, 2017/05/03 22:05:11]

nit: blank line after

[shivanisha, 2017/05/04 20:20:57]

done

+#import "chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.h"
+
+//@class ContentSettingBubbleController;

[Robert Sesek, 2017/05/03 22:05:11]

Remove

[shivanisha, 2017/05/04 20:20:57]

done

+
+// Displays the content filtering bubble. This is a bubble which is shown
+// through content settings when the user proceeds through a Safe Browsing
+// warning interstitial that is displayed when the site ahead contains deceptive
+// embedded content. It explains to the user that some subresources were
+// filtered and presents the checkbox to enable those resources. If the check
+// box is checked, the OK button's text is replaced with Reload giving the user
+// the ability to reload the page with the content we've blocked previously.
+@interface SubresourceFilterBubbleController : ContentSettingBubbleController {

[Robert Sesek, 2017/05/03 22:05:11]

The modern Cocoa style is to not declare instance variables in the header. You
can instead move this into the .mm file by changing the line:

"@interface SubresourceFilterBubbleController (Private)"

To:

"
@interface SubresourceFilterBubbleController () {
  NSButton* manageCheckbox_;
}
"

[shivanisha, 2017/05/04 20:20:57]

done

+ @private
+  IBOutlet NSButton* manageCheckbox_;

[Robert Sesek, 2017/05/03 22:05:11]

|IBOutlet| is magic used for XIB files, so you don't need it here.

[shivanisha, 2017/05/04 20:20:57]

done

+}
+
+@end
+
+#endif  // CHROME_BROWSER_UI_COCOA_SUBRESOURCE_FILTER_SUBRESOURCE_FILTER_BUBBLE_CONTROLLER_H_