Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4017)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

Issue 2826223002: Hide Chrome actions in notifications shown for WebAPKs (Closed)
Patch Set: Update CustomNotificationBuilder. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
index b66d3dc3956cca8801bc99c1aa640b8bbd5ea81a..1565140c06def8524895d51637b1a1f2f2f08c1d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
@@ -232,6 +232,10 @@ public class CustomNotificationBuilder extends NotificationBuilderBase {
private void configureSettingsButton(RemoteViews bigView) {
if (mSettingsAction == null) {
+ bigView.setViewVisibility(R.id.origin_settings_icon, View.GONE);
+ int padding =
+ dpToPx(BUTTON_ICON_PADDING_DP, mContext.getResources().getDisplayMetrics());
+ bigView.setViewPadding(R.id.origin, padding, 0, padding, 0);
Peter Beverloo 2017/04/20 19:08:29 Hmmm could you make a screenshot of what you see?
Xi Han 2017/04/20 20:14:20 Change the padding to 0, 0, 8, 0. Only leave the p
return;
}
bigView.setOnClickPendingIntent(R.id.origin, mSettingsAction.intent);

Powered by Google App Engine
This is Rietveld 408576698