Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(973)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/css-display-3/display-contents-line-height.html
Issue
2826153002
:
Don't assume line-height properties can't change between text and its container.
Patch Set: Don't assume line-height properties can't change between text and its container.
Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/css-display-3/display-contents-line-height.html
third_party/WebKit/LayoutTests/css-display-3/display-contents-line-height-expected.html
third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/css-display-3/display-contents-line-height-expected.html »
('j') |
third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!doctype html>
2
<style>
3
.container {
4
border: 1px solid black;
5
display: flex;
6
height: 100px;
7
align-items: flex-end;
8
}
9
10
.contents {
11
display: contents;
12
font-size: 50px;
13
}
14
</style>
15
<div class="container"><div class="contents">Text should remain in the container </div></div>
OLD
NEW
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/css-display-3/display-contents-line-height-expected.html »
('j') |
third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp »
('J')
Issue 2826153002: Don't assume line-height properties can't change between text and its container.
Created 3 years, 8 months ago by emilio
Modified 3 years, 4 months ago
Reviewers: eae
Base URL:
Comments: 1
This is Rietveld
408576698