Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: tools/grit/grit_rule.gni

Issue 2826113002: Remove use_qualified_include from grit_rule.gni (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libaddressinput/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/grit/grit_rule.gni
diff --git a/tools/grit/grit_rule.gni b/tools/grit/grit_rule.gni
index 367ea816f6b2a1b112aad77581b07dfc788db18c..f436d3a3f5a1b7a0056032a519d655964ba2253c 100644
--- a/tools/grit/grit_rule.gni
+++ b/tools/grit/grit_rule.gni
@@ -63,9 +63,6 @@
# If set, used to store the depfile and corresponding stamp file.
# Defaults to output_dir
#
-# use_qualified_include (optional)
-# If set to false, output_dir is added to include_dirs.
-#
# configs (optional)
# List of additional configs to be applied to the generated target.
# deps (optional)
@@ -345,17 +342,9 @@ template("grit") {
# overwritten inside the inner classes so we need to compute it here.
target_visibility = [ ":$target_name" ]
- # The current grit setup makes an file in $output_dir/grit/foo.h that
- # the source code expects to include via "grit/foo.h". It would be nice to
- # change this to including absolute paths relative to the root gen directory
- # (like "mycomponent/foo.h"). This config sets up the include path.
+ # This config sets up flags needed for enable_resource_whitelist_generation.
grit_config = target_name + "_grit_config"
config(grit_config) {
- if (defined(invoker.use_qualified_include) &&
- !invoker.use_qualified_include) {
- include_dirs = [ output_dir ]
- }
-
if ((is_linux || is_android) && enable_resource_whitelist_generation) {
cflags = [
"-Wunknown-pragmas",
« no previous file with comments | « third_party/libaddressinput/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698