Issue 2826083002: Remove backend dependency from TypeTestRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2826083002: Remove backend dependency from TypeTestRegistry (Closed)

Created:
3 years, 8 months ago by Johnni Winther

Modified:
3 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Remove backend dependency from TypeTestRegistry - and move RuntimeTypesChecks to TypeTestRegistry. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/ab195dac6341dba5c373a573fe711834875d9b8b

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -48 lines)			Patch
M	pkg/compiler/lib/src/js_backend/backend.dart	View	3 chunks	+1 line, -13 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/runtime_types.dart	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/code_emitter_task.dart	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/type_test_registry.dart	View	10 chunks	+43 lines, -27 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 8 months ago (2017-04-20 07:32:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ab195dac6341dba5c373a573fe711834875d9b8b (presubmit successful).