Do not share FBOs/VAOs/Transform feedback objects across contexts

gpu/command_buffer/build_gles2_cmd_buffer.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """code generator for GLES2 command buffers."""
 
 import itertools
 import os
 import os.path
@@ skipping 2899 matching lines @@
   },
   'GenMailboxCHROMIUM': {
     'type': 'NoCommand',
     'extension': "CHROMIUM_texture_mailbox",
   },
   'GenFramebuffers': {
     'type': 'GENn',
     'gl_test_func': 'glGenFramebuffersEXT',
     'resource_type': 'Framebuffer',
     'resource_types': 'Framebuffers',
+    'not_shared': 'True',
   },
   'GenRenderbuffers': {
     'type': 'GENn', 'gl_test_func': 'glGenRenderbuffersEXT',
     'resource_type': 'Renderbuffer',
     'resource_types': 'Renderbuffers',
   },
   'GenSamplers': {
     'type': 'GENn',
     'gl_test_func': 'glGenSamplers',
     'resource_type': 'Sampler',
     'resource_types': 'Samplers',
     'es3': True,
   },
   'GenTextures': {
     'type': 'GENn',
     'gl_test_func': 'glGenTextures',
     'resource_type': 'Texture',
     'resource_types': 'Textures',
   },
   'GenTransformFeedbacks': {
     'type': 'GENn',
     'gl_test_func': 'glGenTransformFeedbacks',
     'resource_type': 'TransformFeedback',
     'resource_types': 'TransformFeedbacks',
     'es3': True,
+    'not_shared': 'True',
   },
   'GetActiveAttrib': {
     'type': 'Custom',
     'data_transfer_methods': ['shm'],
     'cmd_args':
         'GLidProgram program, GLuint index, uint32_t name_bucket_id, '
         'void* result',
     'result': [
       'int32_t success',
       'int32_t size',
@@ skipping 1283 matching lines @@
   },
 
   'GenVertexArraysOES': {
     'type': 'GENn',
     'extension': 'OES_vertex_array_object',
     'gl_test_func': 'glGenVertexArraysOES',
     'resource_type': 'VertexArray',
     'resource_types': 'VertexArrays',
     'unit_test': False,
     'pepper_interface': 'VertexArrayObject',
+    'not_shared': 'True',
   },
   'BindVertexArrayOES': {
     'type': 'Bind',
     'extension': 'OES_vertex_array_object',
     'gl_test_func': 'glBindVertexArrayOES',
     'decoder_func': 'DoBindVertexArrayOES',
     'gen_func': 'GenVertexArraysOES',
     'unit_test': False,
     'client_test': False,
     'pepper_interface': 'VertexArrayObject',
@@ skipping 1774 matching lines @@
         "%(return_type)s GLES2Implementation::%(name)s(%(typed_args)s) {\n" %
         args)
     func.WriteDestinationInitalizationValidation(f)
     self.WriteClientGLCallLog(func, f)
     for arg in func.GetOriginalArgs():
       arg.WriteClientSideValidationCode(f, func)
     not_shared = func.GetInfo('not_shared')
     if not_shared:
       alloc_code = (
 
-"""  IdAllocator* id_allocator = GetIdAllocator(id_namespaces::k%s);
+"""  IdAllocator* id_allocator = GetIdAllocator(ToInt(IdNamespaces::k%s));

[Zhenyao Mo, 2017/05/11 22:10:57]

This defeats the purpose of using enum classes. The purpose is we don't
accidentally pass a wrong resource_type into this function.  If you map to int,
then it can still happen.

The ToInt needs to be moved into GetIdAllocator, and the function arg still
needs to be enum class type.

[Chandan, 2017/05/12 12:30:31]

Acknowledged.

   for (GLsizei ii = 0; ii < n; ++ii)
     %s[ii] = id_allocator->AllocateID();""" %
   (func.GetInfo('resource_types'), func.GetOriginalArgs()[1].name))
     else:
-      alloc_code = ("""  GetIdHandler(id_namespaces::k%(resource_types)s)->
+      alloc_code = ("""  GetIdHandler(ToInt(SharedIdNamespaces::k%(resource_types)s))->

[Chandan, 2017/05/10 14:47:37]

How do we format python files in chromium? 

[Zhenyao Mo, 2017/05/11 22:10:57]

You can move """... to the next line

[Zhenyao Mo, 2017/05/11 22:10:57]

Same here.

[Chandan, 2017/05/12 12:30:31]

Done.

       MakeIds(this, 0, %(args)s);""" % args)
     args['alloc_code'] = alloc_code
 
     code = """ GPU_CLIENT_SINGLE_THREAD_CHECK();
 %(alloc_code)s
   %(name)sHelper(%(args)s);
   helper_->%(name)sImmediate(%(args)s);
   if (share_group_->bind_generates_resource())
     helper_->CommandBufferHelper::Flush();
 %(log_code)s
@@ skipping 283 matching lines @@
                (func.return_type, func.original_name,
                 func.MakeTypedOriginalArgString("")))
     f.write("  GPU_CLIENT_SINGLE_THREAD_CHECK();\n")
     func.WriteDestinationInitalizationValidation(f)
     self.WriteClientGLCallLog(func, f)
     for arg in func.GetOriginalArgs():
       arg.WriteClientSideValidationCode(f, func)
     f.write("  GLuint client_id;\n")
     if func.return_type == "GLsync":
       f.write(
-          "  GetIdHandler(id_namespaces::kSyncs)->\n")
+          "  GetIdHandler(ToInt(SharedIdNamespaces::kSyncs))->\n")
     else:
       f.write(
-          "  GetIdHandler(id_namespaces::kProgramsAndShaders)->\n")
+          "  GetIdHandler(ToInt(SharedIdNamespaces::kProgramsAndShaders))->\n")
     f.write("      MakeIds(this, 0, 1, &client_id);\n")
     f.write("  helper_->%s(%s);\n" %
                (func.name, func.MakeCmdArgString("")))
     f.write('  GPU_CLIENT_LOG("returned " << client_id);\n')
     f.write("  CheckGLError();\n")
     if func.return_type == "GLsync":
       f.write("  return reinterpret_cast<GLsync>(client_id);\n")
     else:
       f.write("  return client_id;\n")
     f.write("}\n")
@@ skipping 4909 matching lines @@
   Format(gen.generated_cpp_filenames)
 
   if gen.errors > 0:
     print "%d errors" % gen.errors
     return 1
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))