List relevant IDs from Finch in snippets-internals

chrome/browser/ui/webui/snippets_internals_message_handler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/snippets_internals_message_handler.h"
 
 #include <memory>
 #include <set>
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/i18n/time_formatting.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
+#include "base/metrics/field_trial.h"
 #include "base/optional.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
+#include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/android/chrome_feature_list.h"
 #include "chrome/browser/ntp_snippets/content_suggestions_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_features.h"
 #include "components/ntp_snippets/category.h"
 #include "components/ntp_snippets/category_info.h"
 #include "components/ntp_snippets/features.h"
 #include "components/ntp_snippets/pref_names.h"
 #include "components/ntp_snippets/remote/remote_suggestions_fetcher.h"
 #include "components/ntp_snippets/remote/remote_suggestions_provider.h"
 #include "components/ntp_snippets/switches.h"
 #include "components/offline_pages/core/offline_page_feature.h"
 #include "components/prefs/pref_service.h"
+#include "components/variations/variations_associated_data.h"
 #include "content/public/browser/web_ui.h"
 
 using ntp_snippets::ContentSuggestion;
 using ntp_snippets::Category;
 using ntp_snippets::CategoryInfo;
 using ntp_snippets::CategoryStatus;
 using ntp_snippets::KnownCategories;
 using ntp_snippets::RemoteSuggestionsProvider;
 using ntp_snippets::UserClassifier;
 
@@ skipping 64 matching lines @@
     case CategoryStatus::ALL_SUGGESTIONS_EXPLICITLY_DISABLED:
       return "ALL_SUGGESTIONS_EXPLICITLY_DISABLED";
     case CategoryStatus::CATEGORY_EXPLICITLY_DISABLED:
       return "CATEGORY_EXPLICITLY_DISABLED";
     case CategoryStatus::LOADING_ERROR:
       return "LOADING_ERROR";
   }
   return std::string();
 }
 
+std::set<variations::VariationID> SnippetsExperiments() {
+  std::set<variations::VariationID> result;
+  for (const base::Feature* const* feature = ntp_snippets::kAllFeatures;
+       *feature; ++feature) {
+    base::FieldTrial* trial = base::FeatureList::GetFieldTrial(**feature);
+    if (!trial) {
+      continue;
+    }
+    if (trial->GetGroupNameWithoutActivation().empty()) {
+      continue;
+    }
+    for (variations::IDCollectionKey key :
+         {variations::GOOGLE_WEB_PROPERTIES,
+          variations::GOOGLE_WEB_PROPERTIES_SIGNED_IN,
+          variations::GOOGLE_WEB_PROPERTIES_TRIGGER}) {
+      const variations::VariationID id = variations::GetGoogleVariationID(
+          key, trial->trial_name(), trial->group_name());

[jkrcal, 2017/04/19 11:15:43]

Just want to double check: The fact that the group name is not empty implies
that the group is already activated and we can thus simply call
trial->group_name()?

[sfiera, 2017/04/19 11:40:18]

Yes, from my reading of the code, a non-empty group name implies the group is
already active.

I'm not sure if the empty string is a valid group name; if it is, then we would
miss experiment IDs from such a group. But I don't think we'll do that anyway.

[jkrcal, 2017/04/19 11:45:17]

Acknowledged.

+      if (id != variations::EMPTY_ID) {
+        result.insert(id);
+      }
+    }
+  }
+  return result;
+}
+
 }  // namespace
 
 SnippetsInternalsMessageHandler::SnippetsInternalsMessageHandler(
     ntp_snippets::ContentSuggestionsService* content_suggestions_service,
     PrefService* pref_service)
     : content_suggestions_service_observer_(this),
       dom_loaded_(false),
       content_suggestions_service_(content_suggestions_service),
       remote_suggestions_provider_(
           content_suggestions_service_
@@ skipping 218 matching lines @@
 
   if (remote_suggestions_provider_) {
     const ntp_snippets::RemoteSuggestionsFetcher* fetcher =
         remote_suggestions_provider_->suggestions_fetcher_for_debugging();
     SendString("switch-fetch-url", fetcher->fetch_url().spec());
     web_ui()->CallJavascriptFunctionUnsafe(
         "chrome.SnippetsInternals.receiveJson",
         base::Value(fetcher->last_json()));
   }
 
+  std::set<variations::VariationID> ids = SnippetsExperiments();
+  std::vector<std::string> string_ids;
+  for (auto id : ids) {
+    string_ids.push_back(base::IntToString(id));
+  }
+  SendString("experiment-ids", base::JoinString(string_ids, ", "));
+
   SendContentSuggestions();
 }
 
 void SnippetsInternalsMessageHandler::SendClassification() {
   web_ui()->CallJavascriptFunctionUnsafe(
       "chrome.SnippetsInternals.receiveClassification",
       base::Value(content_suggestions_service_->user_classifier()
                       ->GetUserClassDescriptionForDebugging()),
       base::Value(
           content_suggestions_service_->user_classifier()->GetEstimatedAvgTime(
@@ skipping 85 matching lines @@
 void SnippetsInternalsMessageHandler::OnDismissedSuggestionsLoaded(
     Category category,
     std::vector<ContentSuggestion> dismissed_suggestions) {
   if (dismissed_state_[category] == DismissedState::HIDDEN) {
     return;
   }
   dismissed_suggestions_[category] = std::move(dismissed_suggestions);
   dismissed_state_[category] = DismissedState::VISIBLE;
   SendContentSuggestions();
 }