Removed translate MetricsNameIndex.

components/translate/core/common/translate_metrics_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/common/translate_metrics.h"
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/metrics/histogram.h"
@@ skipping 19 matching lines @@
 class MetricsRecorder {
  public:
   explicit MetricsRecorder(const char* key) : key_(key) {
     StatisticsRecorder::Initialize();
 
     HistogramBase* histogram = StatisticsRecorder::FindHistogram(key_);
     if (histogram)
       base_samples_ = histogram->SnapshotSamples();
   }
 
-  void CheckLanguage(translate::MetricsNameIndex index,
+  void CheckLanguage(const char* metric_name,
                      int expected_not_provided,
                      int expected_valid,
                      int expected_invalid) {
-    ASSERT_EQ(translate::GetMetricsName(index), key_);
+    ASSERT_EQ(metric_name, key_);
 
     Snapshot();
 
     EXPECT_EQ(expected_not_provided,
               GetCountWithoutSnapshot(translate::LANGUAGE_NOT_PROVIDED));
     EXPECT_EQ(expected_valid,
               GetCountWithoutSnapshot(translate::LANGUAGE_VALID));
     EXPECT_EQ(expected_invalid,
               GetCountWithoutSnapshot(translate::LANGUAGE_INVALID));
   }
 
   void CheckLanguageVerification(int expected_cld_disabled,
                                  int expected_cld_only,
                                  int expected_unknown,
                                  int expected_cld_agree,
                                  int expected_cld_disagree,
                                  int expected_trust_cld,
                                  int expected_cld_complement_sub_code) {
-    ASSERT_EQ(translate::GetMetricsName(translate::UMA_LANGUAGE_VERIFICATION),
+    ASSERT_EQ(translate::metrics_internal::kTranslateLanguageVerification,
               key_);
 
     Snapshot();
 
     EXPECT_EQ(
         expected_cld_disabled,
         GetCountWithoutSnapshot(translate::LANGUAGE_VERIFICATION_CLD_DISABLED));
     EXPECT_EQ(
         expected_cld_only,
         GetCountWithoutSnapshot(translate::LANGUAGE_VERIFICATION_CLD_ONLY));
-    EXPECT_EQ(
-        expected_unknown,
-        GetCountWithoutSnapshot(translate::LANGUAGE_VERIFICATION_UNKNOWN));
+    EXPECT_EQ(expected_unknown, GetCountWithoutSnapshot(
+                                    translate::LANGUAGE_VERIFICATION_UNKNOWN));
     EXPECT_EQ(
         expected_cld_agree,
         GetCountWithoutSnapshot(translate::LANGUAGE_VERIFICATION_CLD_AGREE));
     EXPECT_EQ(
         expected_cld_disagree,
         GetCountWithoutSnapshot(translate::LANGUAGE_VERIFICATION_CLD_DISAGREE));
     EXPECT_EQ(
         expected_trust_cld,
         GetCountWithoutSnapshot(translate::LANGUAGE_VERIFICATION_TRUST_CLD));
     EXPECT_EQ(expected_cld_complement_sub_code,
               GetCountWithoutSnapshot(
                   translate::LANGUAGE_VERIFICATION_CLD_COMPLEMENT_SUB_CODE));
   }
 
   void CheckScheme(int expected_http, int expected_https, int expected_others) {
-    ASSERT_EQ(translate::GetMetricsName(translate::UMA_PAGE_SCHEME), key_);
+    ASSERT_EQ(translate::metrics_internal::kTranslatePageScheme, key_);
 
     Snapshot();
 
     EXPECT_EQ(expected_http, GetCountWithoutSnapshot(translate::SCHEME_HTTP));
     EXPECT_EQ(expected_https, GetCountWithoutSnapshot(translate::SCHEME_HTTPS));
     EXPECT_EQ(expected_others,
               GetCountWithoutSnapshot(translate::SCHEME_OTHERS));
   }
 
   void CheckTotalCount(int count) {
@@ skipping 51 matching lines @@
   std::unique_ptr<HistogramSamples> base_samples_;
   std::unique_ptr<HistogramSamples> samples_;
 
   DISALLOW_COPY_AND_ASSIGN(MetricsRecorder);
 };
 
 }  // namespace
 
 TEST(TranslateMetricsTest, ReportContentLanguage) {
   MetricsRecorder recorder(
-      translate::GetMetricsName(translate::UMA_CONTENT_LANGUAGE));
+      translate::metrics_internal::kTranslateContentLanguage);
 
-  recorder.CheckLanguage(translate::UMA_CONTENT_LANGUAGE, 0, 0, 0);
+  recorder.CheckLanguage(translate::metrics_internal::kTranslateContentLanguage,
+                         0, 0, 0);
   translate::ReportContentLanguage(std::string(), std::string());
-  recorder.CheckLanguage(translate::UMA_CONTENT_LANGUAGE, 1, 0, 0);
+  recorder.CheckLanguage(translate::metrics_internal::kTranslateContentLanguage,
+                         1, 0, 0);
   translate::ReportContentLanguage("ja_JP", "ja-JP");
-  recorder.CheckLanguage(translate::UMA_CONTENT_LANGUAGE, 1, 0, 1);
+  recorder.CheckLanguage(translate::metrics_internal::kTranslateContentLanguage,
+                         1, 0, 1);
   translate::ReportContentLanguage("en", "en");
-  recorder.CheckLanguage(translate::UMA_CONTENT_LANGUAGE, 1, 1, 1);
+  recorder.CheckLanguage(translate::metrics_internal::kTranslateContentLanguage,
+                         1, 1, 1);
 }
 
 TEST(TranslateMetricsTest, ReportHtmlLang) {
-  MetricsRecorder recorder(translate::GetMetricsName(translate::UMA_HTML_LANG));
+  MetricsRecorder recorder(translate::metrics_internal::kTranslateHtmlLang);
 
-  recorder.CheckLanguage(translate::UMA_HTML_LANG, 0, 0, 0);
+  recorder.CheckLanguage(translate::metrics_internal::kTranslateHtmlLang, 0, 0,
+                         0);
   translate::ReportHtmlLang(std::string(), std::string());
-  recorder.CheckLanguage(translate::UMA_HTML_LANG, 1, 0, 0);
+  recorder.CheckLanguage(translate::metrics_internal::kTranslateHtmlLang, 1, 0,
+                         0);
   translate::ReportHtmlLang("ja_JP", "ja-JP");
-  recorder.CheckLanguage(translate::UMA_HTML_LANG, 1, 0, 1);
+  recorder.CheckLanguage(translate::metrics_internal::kTranslateHtmlLang, 1, 0,
+                         1);
   translate::ReportHtmlLang("en", "en");
-  recorder.CheckLanguage(translate::UMA_HTML_LANG, 1, 1, 1);
+  recorder.CheckLanguage(translate::metrics_internal::kTranslateHtmlLang, 1, 1,
+                         1);
 }
 
 TEST(TranslateMetricsTest, ReportLanguageVerification) {
   MetricsRecorder recorder(
-      translate::GetMetricsName(translate::UMA_LANGUAGE_VERIFICATION));
+      translate::metrics_internal::kTranslateLanguageVerification);
 
   recorder.CheckLanguageVerification(0, 0, 0, 0, 0, 0, 0);
   translate::ReportLanguageVerification(
       translate::LANGUAGE_VERIFICATION_CLD_DISABLED);
   recorder.CheckLanguageVerification(1, 0, 0, 0, 0, 0, 0);
   translate::ReportLanguageVerification(
       translate::LANGUAGE_VERIFICATION_CLD_ONLY);
   recorder.CheckLanguageVerification(1, 1, 0, 0, 0, 0, 0);
   translate::ReportLanguageVerification(
       translate::LANGUAGE_VERIFICATION_UNKNOWN);
   recorder.CheckLanguageVerification(1, 1, 1, 0, 0, 0, 0);
   translate::ReportLanguageVerification(
       translate::LANGUAGE_VERIFICATION_CLD_AGREE);
   recorder.CheckLanguageVerification(1, 1, 1, 1, 0, 0, 0);
   translate::ReportLanguageVerification(
       translate::LANGUAGE_VERIFICATION_CLD_DISAGREE);
   recorder.CheckLanguageVerification(1, 1, 1, 1, 1, 0, 0);
   translate::ReportLanguageVerification(
       translate::LANGUAGE_VERIFICATION_TRUST_CLD);
   recorder.CheckLanguageVerification(1, 1, 1, 1, 1, 1, 0);
   translate::ReportLanguageVerification(
       translate::LANGUAGE_VERIFICATION_CLD_COMPLEMENT_SUB_CODE);
   recorder.CheckLanguageVerification(1, 1, 1, 1, 1, 1, 1);
 }
 
 TEST(TranslateMetricsTest, ReportTimeToBeReady) {
   MetricsRecorder recorder(
-      translate::GetMetricsName(translate::UMA_TIME_TO_BE_READY));
+      translate::metrics_internal::kTranslateTimeToBeReady);
   recorder.CheckTotalCount(0);
   translate::ReportTimeToBeReady(3.14);
   recorder.CheckValueInLogs(3.14);
   recorder.CheckTotalCount(1);
 }
 
 TEST(TranslateMetricsTest, ReportTimeToLoad) {
-  MetricsRecorder recorder(
-      translate::GetMetricsName(translate::UMA_TIME_TO_LOAD));
+  MetricsRecorder recorder(translate::metrics_internal::kTranslateTimeToLoad);
   recorder.CheckTotalCount(0);
   translate::ReportTimeToLoad(573.0);
   recorder.CheckValueInLogs(573.0);
   recorder.CheckTotalCount(1);
 }
 
 TEST(TranslateMetricsTest, ReportTimeToTranslate) {
   MetricsRecorder recorder(
-      translate::GetMetricsName(translate::UMA_TIME_TO_TRANSLATE));
+      translate::metrics_internal::kTranslateTimeToTranslate);
   recorder.CheckTotalCount(0);
   translate::ReportTimeToTranslate(4649.0);
   recorder.CheckValueInLogs(4649.0);
   recorder.CheckTotalCount(1);
 }
 
 TEST(TranslateMetricsTest, ReportUserActionDuration) {
   MetricsRecorder recorder(
-      translate::GetMetricsName(translate::UMA_USER_ACTION_DURATION));
+      translate::metrics_internal::kTranslateUserActionDuration);
   recorder.CheckTotalCount(0);
   TimeTicks begin = TimeTicks::Now();
   TimeTicks end = begin + base::TimeDelta::FromSeconds(3776);
   translate::ReportUserActionDuration(begin, end);
   recorder.CheckValueInLogs(3776000.0);
   recorder.CheckTotalCount(1);
 }
 
 TEST(TranslateMetricsTest, ReportPageScheme) {
-  MetricsRecorder recorder(
-      translate::GetMetricsName(translate::UMA_PAGE_SCHEME));
+  MetricsRecorder recorder(translate::metrics_internal::kTranslatePageScheme);
   recorder.CheckScheme(0, 0, 0);
   translate::ReportPageScheme("http");
   recorder.CheckScheme(1, 0, 0);
   translate::ReportPageScheme("https");
   recorder.CheckScheme(1, 1, 0);
   translate::ReportPageScheme("ftp");
   recorder.CheckScheme(1, 1, 1);
 }
 
 TEST(TranslateMetricsTest, ReportSimilarLanguageMatch) {
   MetricsRecorder recorder(
-      translate::GetMetricsName(translate::UMA_SIMILAR_LANGUAGE_MATCH));
+      translate::metrics_internal::kTranslateSimilarLanguageMatch);
   recorder.CheckTotalCount(0);
   EXPECT_EQ(0, recorder.GetCount(kTrue));
   EXPECT_EQ(0, recorder.GetCount(kFalse));
   translate::ReportSimilarLanguageMatch(true);
   EXPECT_EQ(1, recorder.GetCount(kTrue));
   EXPECT_EQ(0, recorder.GetCount(kFalse));
   translate::ReportSimilarLanguageMatch(false);
   EXPECT_EQ(1, recorder.GetCount(kTrue));
   EXPECT_EQ(1, recorder.GetCount(kFalse));
 }
 
 TEST(TranslateMetricsTest, ReportLanguageDetectionTime) {
   MetricsRecorder recorder(
-      translate::GetMetricsName(translate::UMA_LANGUAGE_DETECTION));
+      translate::metrics_internal::kRenderer4LanguageDetection);
   recorder.CheckTotalCount(0);
   TimeTicks begin = TimeTicks::Now();
   TimeTicks end = begin + base::TimeDelta::FromMicroseconds(9009);
   translate::ReportLanguageDetectionTime(begin, end);
   recorder.CheckValueInLogs(9.009);
   recorder.CheckTotalCount(1);
 }
 
 TEST(TranslateMetricsTest, ReportLanguageDetectionConflict) {
   MetricsRecorder recorder(
-      translate::GetMetricsName(translate::UMA_LANGUAGE_DETECTION_CONFLICT));
+      translate::metrics_internal::kTranslateLanguageDetectionConflict);
   recorder.CheckTotalCount(0);
 
   translate::ReportLanguageDetectionConflict("en", "es");
   recorder.CheckTotalCount(1);
   EXPECT_EQ(recorder.GetCount(base::HashMetricName("en,es")), 1);
 
   translate::ReportLanguageDetectionConflict("en", "es");
   recorder.CheckTotalCount(2);
   EXPECT_EQ(recorder.GetCount(base::HashMetricName("en,es")), 2);
 
   translate::ReportLanguageDetectionConflict("en-AU", "ru-Latn");
   recorder.CheckTotalCount(3);
   EXPECT_EQ(recorder.GetCount(base::HashMetricName("en-AU,ru-Latn")), 1);
 
   // We don't track "en-XX" or "en-YY" as page codes.
   translate::ReportLanguageDetectionConflict("en-XX", "es");
   translate::ReportLanguageDetectionConflict("en-YY", "es");
   recorder.CheckTotalCount(5);
   EXPECT_EQ(recorder.GetCount(base::HashMetricName("other,es")), 2);
 }
 
 }  // namespace translate