Removed translate MetricsNameIndex.

components/translate/core/common/translate_metrics.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_TRANSLATE_CORE_COMMON_TRANSLATE_METRICS_H_
 #define COMPONENTS_TRANSLATE_CORE_COMMON_TRANSLATE_METRICS_H_
 
 #include <string>
 
 #include "base/time/time.h"
 
 namespace translate {
 
-// An indexing type to query each UMA entry name via GetMetricsName() function.
-// Note: |kMetricsEntries| should be updated when a new entry is added here.
-enum MetricsNameIndex {
-  UMA_LANGUAGE_DETECTION,
-  UMA_CONTENT_LANGUAGE,
-  UMA_HTML_LANG,
-  UMA_LANGUAGE_VERIFICATION,
-  UMA_TIME_TO_BE_READY,
-  UMA_TIME_TO_LOAD,
-  UMA_TIME_TO_TRANSLATE,
-  UMA_USER_ACTION_DURATION,
-  UMA_PAGE_SCHEME,
-  UMA_SIMILAR_LANGUAGE_MATCH,
-  UMA_LANGUAGE_DETECTION_CONFLICT,
-  UMA_MAX,
-};
+// Internals exposed for testing purposes. Should not be relied on by client
+// code.
+namespace metrics_internal {

[droger, 2017/04/19 08:26:49]

Optional: I think the namespace is not even needed. Using a namespace is fine
too, but I think namespaces may increase the binary size (not sure about the
details).

[martis, 2017/04/20 02:57:29]

I'm not aware of namespaces increasing the size of (non-debug) binaries. I've
left as-is.

+
+// Constant string values to indicate UMA names.
+extern const char* kRenderer4LanguageDetection;

[droger, 2017/04/19 08:26:49]

extern const char kRenderer4LanguageDetection[]
is the preferred style.(same for all the other constants).

[martis, 2017/04/20 02:57:29]

As far as I know, that syntax can only be used when initializing.

I've moved the declarations into the header in order to use the preferred style.

[droger, 2017/04/20 07:30:30]

No.

Please do like I said in my first comment. You can look for examples in the
codebase.
See for example:
https://cs.chromium.org/chromium/src/components/sync/base/pref_names.h?q=Pref...

+extern const char* kTranslateContentLanguage;
+extern const char* kTranslateHtmlLang;
+extern const char* kTranslateLanguageVerification;
+extern const char* kTranslateTimeToBeReady;
+extern const char* kTranslateTimeToLoad;
+extern const char* kTranslateTimeToTranslate;
+extern const char* kTranslateUserActionDuration;
+extern const char* kTranslatePageScheme;
+extern const char* kTranslateSimilarLanguageMatch;
+extern const char* kTranslateLanguageDetectionConflict;
+
+}  // namespace metrics_internal
 
 // A page may provide a Content-Language HTTP header or a META tag.
 // TranslateHelper checks if a server provides a valid Content-Language.
 enum LanguageCheckType {
   LANGUAGE_NOT_PROVIDED,
   LANGUAGE_VALID,
   LANGUAGE_INVALID,
   LANGUAGE_MAX,
 };
 
@@ skipping 55 matching lines @@
 
 // Called when CLD agreed on a language which is different, but in the similar
 // language list.
 void ReportSimilarLanguageMatch(bool match);
 
 // Called when page language is "en*" and doesn't match the CLD language; i.e
 // when we suspect that the page language is incorrect.
 void ReportLanguageDetectionConflict(const std::string& page_lang,
                                      const std::string& cld_lang);
 
-// Gets UMA name for an entry specified by |index|.
-const char* GetMetricsName(MetricsNameIndex index);
-
 }  // namespace translate
 
 #endif  // COMPONENTS_TRANSLATE_CORE_COMMON_TRANSLATE_METRICS_H_