Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: src/isolate.cc

Issue 2825903002: [inspector] deduplicate stack frames (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.h ('k') | src/objects.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index bc393957aa5134d7f9c2ce47248a68a477fc777f..2dc01358fa3c28e80dd55e4a3e3dfabc79a8c08c 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -717,6 +717,7 @@ class CaptureStackTraceHelper {
AbstractCode::SetStackFrameCache(summ.abstract_code(), new_cache);
}
}
+ frame->set_id(next_id());
return frame;
}
@@ -738,12 +739,19 @@ class CaptureStackTraceHelper {
info->set_column_number(position);
info->set_script_id(summ.script()->id());
info->set_is_wasm(true);
+ info->set_id(next_id());
return info;
}
private:
inline Factory* factory() { return isolate_->factory(); }
+ int next_id() const {
+ int id = isolate_->last_stack_frame_info_id() + 1;
+ isolate_->set_last_stack_frame_info_id(id);
+ return id;
+ }
+
Isolate* isolate_;
};
« no previous file with comments | « src/isolate.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698