Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Side by Side Diff: src/objects-inl.h

Issue 2825903002: [inspector] deduplicate stack frames (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5881 matching lines...) Expand 10 before | Expand all | Expand 10 after
5892 SMI_ACCESSORS(StackFrameInfo, column_number, kColumnNumberIndex) 5892 SMI_ACCESSORS(StackFrameInfo, column_number, kColumnNumberIndex)
5893 SMI_ACCESSORS(StackFrameInfo, script_id, kScriptIdIndex) 5893 SMI_ACCESSORS(StackFrameInfo, script_id, kScriptIdIndex)
5894 ACCESSORS(StackFrameInfo, script_name, Object, kScriptNameIndex) 5894 ACCESSORS(StackFrameInfo, script_name, Object, kScriptNameIndex)
5895 ACCESSORS(StackFrameInfo, script_name_or_source_url, Object, 5895 ACCESSORS(StackFrameInfo, script_name_or_source_url, Object,
5896 kScriptNameOrSourceUrlIndex) 5896 kScriptNameOrSourceUrlIndex)
5897 ACCESSORS(StackFrameInfo, function_name, Object, kFunctionNameIndex) 5897 ACCESSORS(StackFrameInfo, function_name, Object, kFunctionNameIndex)
5898 SMI_ACCESSORS(StackFrameInfo, flag, kFlagIndex) 5898 SMI_ACCESSORS(StackFrameInfo, flag, kFlagIndex)
5899 BOOL_ACCESSORS(StackFrameInfo, flag, is_eval, kIsEvalBit) 5899 BOOL_ACCESSORS(StackFrameInfo, flag, is_eval, kIsEvalBit)
5900 BOOL_ACCESSORS(StackFrameInfo, flag, is_constructor, kIsConstructorBit) 5900 BOOL_ACCESSORS(StackFrameInfo, flag, is_constructor, kIsConstructorBit)
5901 BOOL_ACCESSORS(StackFrameInfo, flag, is_wasm, kIsWasmBit) 5901 BOOL_ACCESSORS(StackFrameInfo, flag, is_wasm, kIsWasmBit)
5902 SMI_ACCESSORS(StackFrameInfo, id, kIdIndex)
5902 5903
5903 ACCESSORS(SourcePositionTableWithFrameCache, source_position_table, ByteArray, 5904 ACCESSORS(SourcePositionTableWithFrameCache, source_position_table, ByteArray,
5904 kSourcePositionTableIndex) 5905 kSourcePositionTableIndex)
5905 ACCESSORS(SourcePositionTableWithFrameCache, stack_frame_cache, 5906 ACCESSORS(SourcePositionTableWithFrameCache, stack_frame_cache,
5906 UnseededNumberDictionary, kStackFrameCacheIndex) 5907 UnseededNumberDictionary, kStackFrameCacheIndex)
5907 5908
5908 ACCESSORS(SharedFunctionInfo, name, Object, kNameOffset) 5909 ACCESSORS(SharedFunctionInfo, name, Object, kNameOffset)
5909 ACCESSORS(SharedFunctionInfo, optimized_code_map, FixedArray, 5910 ACCESSORS(SharedFunctionInfo, optimized_code_map, FixedArray,
5910 kOptimizedCodeMapOffset) 5911 kOptimizedCodeMapOffset)
5911 ACCESSORS(SharedFunctionInfo, construct_stub, Code, kConstructStubOffset) 5912 ACCESSORS(SharedFunctionInfo, construct_stub, Code, kConstructStubOffset)
(...skipping 2462 matching lines...) Expand 10 before | Expand all | Expand 10 after
8374 #undef WRITE_BYTE_FIELD 8375 #undef WRITE_BYTE_FIELD
8375 #undef NOBARRIER_READ_BYTE_FIELD 8376 #undef NOBARRIER_READ_BYTE_FIELD
8376 #undef NOBARRIER_WRITE_BYTE_FIELD 8377 #undef NOBARRIER_WRITE_BYTE_FIELD
8377 8378
8378 } // namespace internal 8379 } // namespace internal
8379 } // namespace v8 8380 } // namespace v8
8380 8381
8381 #include "src/objects/object-macros-undef.h" 8382 #include "src/objects/object-macros-undef.h"
8382 8383
8383 #endif // V8_OBJECTS_INL_H_ 8384 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698