[inspector] deduplicate stack frames

src/inspector/v8-debugger.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/inspector/v8-debugger.h"
 
 #include "src/inspector/debugger-script.h"
 #include "src/inspector/inspected-context.h"
 #include "src/inspector/protocol/Protocol.h"
 #include "src/inspector/script-breakpoint.h"
@@ skipping 961 matching lines @@
 
 void V8Debugger::allAsyncTasksCanceled() {
   m_asyncTaskStacks.clear();
   m_recurringTasks.clear();
   m_currentAsyncParent.clear();
   m_currentAsyncCreation.clear();
   m_currentTasks.clear();
   m_parentTask.clear();
   m_asyncTaskCreationStacks.clear();
 
+  m_framesCache.clear();
   m_allAsyncStacks.clear();
   m_asyncStacksCount = 0;
 }
 
 void V8Debugger::muteScriptParsedEvents() {
   ++m_ignoreScriptParsedEventsCounter;
 }
 
 void V8Debugger::unmuteScriptParsedEvents() {
   --m_ignoreScriptParsedEventsCounter;
@@ skipping 37 matching lines @@
   }
   m_recurringTasks.swap(recurringLeft);
   protocol::HashMap<void*, void*> parentLeft;
   for (auto it : m_parentTask) {
     if (m_asyncTaskCreationStacks.find(it.second) == m_asyncTaskStacks.end()) {
       continue;
     }
     parentLeft.insert(it);
   }
   m_parentTask.swap(parentLeft);
+  std::map<int, std::weak_ptr<StackFrame>> framesCache;
+  for (auto it : m_framesCache) {
+    if (!it.second.expired()) framesCache.insert(it);
+  }
+  m_framesCache.swap(framesCache);
 }
 
 void V8Debugger::removeOldAsyncTasks(AsyncTaskToStackTrace& map) {
   AsyncTaskToStackTrace cleanCopy;
   for (auto it : map) {
     if (!it.second.expired()) cleanCopy.insert(it);
   }
   map.swap(cleanCopy);
 }
 
+std::shared_ptr<StackFrame> V8Debugger::symbolize(
+    v8::Local<v8::StackFrame> v8Frame) {
+  auto it = m_framesCache.end();
+  int frameId = 0;
+  if (m_maxAsyncCallStackDepth) {

[dgozman, 2017/04/20 16:38:21]

Choose one...

[kozy, 2017/04/20 17:05:37]

Done.

+    frameId = v8::debug::GetStackFrameId(v8Frame);
+    it = m_framesCache.find(frameId);
+  }
+  if (it != m_framesCache.end()) return it->second.lock();

[dgozman, 2017/04/20 16:38:21]

This can return empty shared_ptr.

[kozy, 2017/04/20 17:05:37]

Done.

+  std::shared_ptr<StackFrame> frame(new StackFrame(v8Frame));
+  // TODO(clemensh): Figure out a way to do this translation only right before
+  // sending the stack trace over wire.
+  if (v8Frame->IsWasm()) frame->translate(&m_wasmTranslation);
+  if (m_maxAsyncCallStacks) {

[dgozman, 2017/04/20 16:38:21]

...or another.

[kozy, 2017/04/20 17:05:37]

Done.

+    m_framesCache[frameId] = frame;
+  }
+  return frame;
+}
+
 void V8Debugger::setMaxAsyncTaskStacksForTest(int limit) {
   m_maxAsyncCallStacks = 0;
   collectOldAsyncStacksIfNeeded();
   m_maxAsyncCallStacks = limit;
 }
 
 }  // namespace v8_inspector