base/trace_event/trace_event_memory_overhead.h - Issue 2825853002: Improvements to uses of base::SmallMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_memory_overhead.h

Issue 2825853002: Improvements to uses of base::SmallMap (Closed)

Patch Set: Review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/trace_event_memory_overhead.h

diff --git a/base/trace_event/trace_event_memory_overhead.h b/base/trace_event/trace_event_memory_overhead.h

index a69c93fed200de667996c045ba8411db05a9c17e..a5d324e062be56bd61a0e878f51c99c4c4e93e1f 100644

--- a/base/trace_event/trace_event_memory_overhead.h

+++ b/base/trace_event/trace_event_memory_overhead.h

@@ -60,7 +60,7 @@ class BASE_EXPORT TraceEventMemoryOverhead {

size_t allocated_size_in_bytes;

size_t resident_size_in_bytes;

};

- using map_type = SmallMap<hash_map<const char*, ObjectCountAndSize>, 16>;

+ using map_type = small_map<hash_map<const char*, ObjectCountAndSize>, 16>;

map_type allocated_objects_;

void AddOrCreateInternal(const char* object_type,