Issue 2825843003: Fix VM crash when encountering an assignment expression in a case expression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2825843003: Fix VM crash when encountering an assignment expression in a case expression. (Closed)

Created:
3 years, 8 months ago by rmacnak

Modified:
3 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix VM crash when encountering an assignment expression in a case expression. Fixes #29370 Issue #29379 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/b15cf1c490d7b6a80597efddacb515f6fb8dd290

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -4 lines)			Patch
M	runtime/vm/parser.cc	View	1 chunk	+3 lines, -4 lines	0 comments	Download
A	tests/language/case_expression_with_assignment_test.dart	View	1 chunk	+28 lines, -0 lines	0 comments	Download
M	tests/language/language_kernel.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 8 months ago (2017-04-18 20:48:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b15cf1c490d7b6a80597efddacb515f6fb8dd290 (presubmit successful).