Issue 29358. Fix for reporting constant errors while evaluating constructor invocations.

Issue 29358. Fix for reporting constant errors while evaluating constructor invocations.

We should not report errors in one file using offsets of node in
another file.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/29358

Committed: https://github.com/dart-lang/sdk/commit/19353f9e633313e9b7452a51e9a80b09a16d25f0

[Brian Wilkerson, 2017-04-18 18:53:21]

lgtm

https://codereview.chromium.org/2825813002/diff/1/pkg/analyzer/lib/src/error/...
File pkg/analyzer/lib/src/error/codes.dart (right):

https://codereview.chromium.org/2825813002/diff/1/pkg/analyzer/lib/src/error/...
pkg/analyzer/lib/src/error/codes.dart:59: "Evaluation of this constant
expression throws an exception.");
I can't see, from the tests, where the error is being reported, so it might not
be as bad as I'm imagining, but this seems vague. Longer term (not for this CL),
is there any reasonable way for us to give more actionable feedback (don't pass
this value for this argument) or more compete information (such as where the
exception will be thrown).

https://codereview.chromium.org/2825813002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/compile_time_error_code_test.dart (right):

https://codereview.chromium.org/2825813002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/compile_time_error_code_test.dart:4799:
CompileTimeErrorCode.CONST_EVAL_THROWS_EXCEPTION
Seems like we still have redundant errors and ought to eventually have a single
error. Perhaps restore the TODO?

[scheglov, 2017-04-18 19:11:03]

https://codereview.chromium.org/2825813002/diff/1/pkg/analyzer/lib/src/error/...
File pkg/analyzer/lib/src/error/codes.dart (right):

https://codereview.chromium.org/2825813002/diff/1/pkg/analyzer/lib/src/error/...
pkg/analyzer/lib/src/error/codes.dart:59: "Evaluation of this constant
expression throws an exception.");
On 2017/04/18 18:53:21, Brian Wilkerson wrote:
> I can't see, from the tests, where the error is being reported, so it might
not
> be as bad as I'm imagining, but this seems vague. Longer term (not for this
CL),
> is there any reasonable way for us to give more actionable feedback (don't
pass
> this value for this argument) or more compete information (such as where the
> exception will be thrown).

Potentially it would be a sequence of places, and/or several reasons at several
places.

For example:

class A {
  const A() : v = new Object();
  final v;
}

class B {
  const B() : a = const A();
  final a;
}

class C {
  const C() : b = const B();
  final b;
}

const c = const C();

We will report an error for the top-level variable "c".
The actual problem is however in A (new Object() instead of const Object()).
Not quite this error code, but I think you get the idea.

https://codereview.chromium.org/2825813002/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/compile_time_error_code_test.dart (right):

https://codereview.chromium.org/2825813002/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/compile_time_error_code_test.dart:4799:
CompileTimeErrorCode.CONST_EVAL_THROWS_EXCEPTION
On 2017/04/18 18:53:21, Brian Wilkerson wrote:
> Seems like we still have redundant errors and ought to eventually have a
single
> error. Perhaps restore the TODO?

I'm restoring it (because removing it later is easy), but I think that the error
might be not redundant.

An attempt to evaluate "const B()" will cause an exception. Even if we have both
declaration of the B constructor (which already complains that "a = new A()" is
not valid), and its usage as "const B()" in the same file, I don't think the
specification distinguish between errors in the same or in different files.

[scheglov, 2017-04-18 19:13:30]

Description was changed from

==========
Issue 29358. Fix for reporting constant errors while evaluating constructor
invocations.

We should not report errors in one file using offsets of node in
another file.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/29358
==========

to

==========
Issue 29358. Fix for reporting constant errors while evaluating constructor
invocations.

We should not report errors in one file using offsets of node in
another file.

R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/29358

Committed:
https://github.com/dart-lang/sdk/commit/19353f9e633313e9b7452a51e9a80b09a16d25f0
==========

[scheglov, 2017-04-18 19:13:31]

Committed patchset #2 (id:20001) manually as
19353f9e633313e9b7452a51e9a80b09a16d25f0 (presubmit successful).