Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 2825793002: js_runtime: LinkedHashMap._makeEmpty may be removed (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

js_runtime: LinkedHashMap._makeEmpty may be removed Since it has no effects and does not throw, it may be scheduled more freely. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/c65b3bee5281f12655d202b3ef60ba0afaa14145

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M sdk/lib/_internal/js_runtime/lib/collection_patch.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 8 months ago (2017-04-18 17:38:09 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 8 months ago (2017-04-18 20:29:26 UTC) #3
sra1
3 years, 8 months ago (2017-04-18 20:58:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c65b3bee5281f12655d202b3ef60ba0afaa14145 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698