Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2164)

Unified Diff: net/quic/core/quic_config.cc

Issue 2825773002: Deprecate FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_config.h ('k') | net/quic/core/quic_config_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_config.cc
diff --git a/net/quic/core/quic_config.cc b/net/quic/core/quic_config.cc
index 9a29d94b1dfe0ea2bbe4c46b3e0a71b6901ee7ee..97936491a367bc62e1e965603258f7d00344d1dd 100644
--- a/net/quic/core/quic_config.cc
+++ b/net/quic/core/quic_config.cc
@@ -341,9 +341,7 @@ QuicConfig::QuicConfig()
connection_migration_disabled_(kNCMR, PRESENCE_OPTIONAL),
alternate_server_address_(kASAD, PRESENCE_OPTIONAL),
force_hol_blocking_(kFHL2, PRESENCE_OPTIONAL),
- support_max_header_list_size_(kSMHL, PRESENCE_OPTIONAL),
- latched_no_socket_receive_buffer_(
- FLAGS_quic_reloadable_flag_quic_no_socket_receive_buffer) {
+ support_max_header_list_size_(kSMHL, PRESENCE_OPTIONAL) {
SetDefaults();
}
@@ -544,22 +542,6 @@ uint32_t QuicConfig::ReceivedInitialSessionFlowControlWindowBytes() const {
return initial_session_flow_control_window_bytes_.GetReceivedValue();
}
-void QuicConfig::SetSocketReceiveBufferToSend(uint32_t tcp_receive_window) {
- if (latched_no_socket_receive_buffer_) {
- QUIC_FLAG_COUNT_N(quic_reloadable_flag_quic_no_socket_receive_buffer, 1, 3);
- } else {
- socket_receive_buffer_.SetSendValue(tcp_receive_window);
- }
-}
-
-bool QuicConfig::HasReceivedSocketReceiveBuffer() const {
- return socket_receive_buffer_.HasReceivedValue();
-}
-
-uint32_t QuicConfig::ReceivedSocketReceiveBuffer() const {
- return socket_receive_buffer_.GetReceivedValue();
-}
-
void QuicConfig::SetDisableConnectionMigration() {
connection_migration_disabled_.SetSendValue(1);
}
@@ -638,11 +620,6 @@ void QuicConfig::ToHandshakeMessage(CryptoHandshakeMessage* out) const {
initial_round_trip_time_us_.ToHandshakeMessage(out);
initial_stream_flow_control_window_bytes_.ToHandshakeMessage(out);
initial_session_flow_control_window_bytes_.ToHandshakeMessage(out);
- if (latched_no_socket_receive_buffer_) {
- QUIC_FLAG_COUNT_N(quic_reloadable_flag_quic_no_socket_receive_buffer, 2, 3);
- } else {
- socket_receive_buffer_.ToHandshakeMessage(out);
- }
connection_migration_disabled_.ToHandshakeMessage(out);
connection_options_.ToHandshakeMessage(out);
alternate_server_address_.ToHandshakeMessage(out);
@@ -689,12 +666,6 @@ QuicErrorCode QuicConfig::ProcessPeerHello(
error = initial_session_flow_control_window_bytes_.ProcessPeerHello(
peer_hello, hello_type, error_details);
}
- if (latched_no_socket_receive_buffer_) {
- QUIC_FLAG_COUNT_N(quic_reloadable_flag_quic_no_socket_receive_buffer, 3, 3);
- } else if (error == QUIC_NO_ERROR) {
- error = socket_receive_buffer_.ProcessPeerHello(peer_hello, hello_type,
- error_details);
- }
if (error == QUIC_NO_ERROR) {
error = connection_migration_disabled_.ProcessPeerHello(
peer_hello, hello_type, error_details);
« no previous file with comments | « net/quic/core/quic_config.h ('k') | net/quic/core/quic_config_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698