Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5041)

Unified Diff: chrome/browser/predictors/resource_prefetch_predictor.h

Issue 2825693002: predictors: Prefetch resources from manifest. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetch_predictor.h
diff --git a/chrome/browser/predictors/resource_prefetch_predictor.h b/chrome/browser/predictors/resource_prefetch_predictor.h
index 750ac83bf01caf114b54e73ea326ccb7b759b08f..49776b15667cc28ad29ca0b1c8d70da0057ced23 100644
--- a/chrome/browser/predictors/resource_prefetch_predictor.h
+++ b/chrome/browser/predictors/resource_prefetch_predictor.h
@@ -63,7 +63,9 @@ constexpr char kResourcePrefetchPredictorPrefetchMissesSize[] =
constexpr char kResourcePrefetchPredictorRedirectStatusHistogram[] =
"ResourcePrefetchPredictor.RedirectStatus";
+const uint32_t kVersionedRemovedExperiment = 0x03ff25e3;
const uint32_t kUnusedRemovedExperiment = 0xf7f77166;
+const uint32_t kNoStoreRemovedExperiment = 0xd90a199a;
} // namespace internal
class TestObserver;
@@ -288,6 +290,8 @@ class ResourcePrefetchPredictor
FRIEND_TEST_ALL_PREFIXES(ResourcePrefetchPredictorTest, HandledResourceTypes);
FRIEND_TEST_ALL_PREFIXES(ResourcePrefetchPredictorTest,
PopulatePrefetcherRequest);
+ FRIEND_TEST_ALL_PREFIXES(ResourcePrefetchPredictorTest,
+ PopulatePrefetcherRequestByManifest);
FRIEND_TEST_ALL_PREFIXES(ResourcePrefetchPredictorTest, GetRedirectEndpoint);
FRIEND_TEST_ALL_PREFIXES(ResourcePrefetchPredictorTest, GetPrefetchData);
FRIEND_TEST_ALL_PREFIXES(ResourcePrefetchPredictorTest,
@@ -364,6 +368,12 @@ class ResourcePrefetchPredictor
const PrefetchDataMap& data_map,
std::vector<GURL>* urls) const;
+ // Returns true iff the manifest table contains PrecacheManifest that can be
+ // used for a |manifest_host| and fills |urls| with resources that need to be
+ // prefetched. |urls| pointer may be equal nullptr to get return value only.
Benoit L 2017/04/18 16:28:39 nit: |urls| may be nullptr to get the return value
alexilin 2017/04/19 07:59:25 Done.
+ bool PopulatePrefetcherRequestByManifest(const std::string& manifest_host,
+ std::vector<GURL>* urls) const;
Benoit L 2017/04/18 16:28:39 nit: PopulateFromManifest()?
alexilin 2017/04/19 07:59:25 Done.
+
// Callback for task to read predictor database. Takes ownership of
// all arguments.
void CreateCaches(std::unique_ptr<PrefetchDataMap> url_data_map,

Powered by Google App Engine
This is Rietveld 408576698