Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2825683002: Add a comments about counter availability in M58/M59 (Closed)

Created:
3 years, 8 months ago by foolip
Modified:
3 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a comments about counter availability in M58/M59 Many things were merged into M58, so some things after the comment are also available. R=tkent@chromium.org NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
foolip
3 years, 8 months ago (2017-04-18 06:51:33 UTC) #1
tkent
lgtm
3 years, 8 months ago (2017-04-18 07:07:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825683002/1
3 years, 8 months ago (2017-04-18 07:11:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/413548)
3 years, 8 months ago (2017-04-18 07:17:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825683002/1
3 years, 8 months ago (2017-04-18 12:12:49 UTC) #12
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/heads/master'. nothing ...
3 years, 8 months ago (2017-04-18 12:15:10 UTC) #14
foolip
3 years, 8 months ago (2017-04-18 13:34:18 UTC) #15
Wow, exactly this was landed in https://codereview.chromium.org/2824943003 (I
rebased without conflicts and my changes disappeared)

Powered by Google App Engine
This is Rietveld 408576698