Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2825633002: Remove the unused HTTP/HTTPS site engagement metrics. (Closed)

Created:
1 year, 2 months ago by dominickn
Modified:
1 year, 2 months ago
Reviewers:
benwells, Ilya Sherman
CC:
chromium-reviews, dominickn+watch_chromium.org, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the unused HTTP/HTTPS site engagement metrics. BUG=712493 Review-Url: https://codereview.chromium.org/2825633002 Cr-Commit-Position: refs/heads/master@{#465170} Committed: https://chromium.googlesource.com/chromium/src/+/8a759adb94636e0b6a1a1b3b07593ea81b2ba576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -58 lines) Patch
M chrome/browser/engagement/site_engagement_metrics.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/engagement/site_engagement_metrics.cc View 4 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/engagement/site_engagement_service_unittest.cc View 5 chunks +0 lines, -28 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
dominickn
benwells: PTAL at engagement/ isherman: PTAL at histograms Thanks!
1 year, 2 months ago (2017-04-18 04:18:58 UTC) #6
Ilya Sherman
LGTM, thank you!
1 year, 2 months ago (2017-04-18 05:14:37 UTC) #7
benwells
lgtm
1 year, 2 months ago (2017-04-18 07:23:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825633002/1
1 year, 2 months ago (2017-04-18 07:26:06 UTC) #10
commit-bot: I haz the power
1 year, 2 months ago (2017-04-18 07:32:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a759adb94636e0b6a1a1b3b0759...

Powered by Google App Engine
This is Rietveld 408576698