DevTools: Make timeline screenshots overlay disapper quickly on mouseout

third_party/WebKit/Source/devtools/front_end/ui/Popover.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
   constructor(container, getRequest) {
     this._disableOnClick = false;
     this._hasPadding = false;
     this._getRequest = getRequest;
     this._scheduledRequest = null;
     /** @type {?function()} */
     this._hidePopoverCallback = null;
     container.addEventListener('mousedown', this._mouseDown.bind(this), false);
     container.addEventListener('mousemove', this._mouseMove.bind(this), false);
     container.addEventListener('mouseout', this._mouseOut.bind(this), false);
-    this.setTimeout(1000, 500);
+    this.setTimeout(1000);
   }
 
   /**
-   * @param {number} timeout
+   * @param {number} showTimeout
    * @param {number=} hideTimeout
    */
-  setTimeout(timeout, hideTimeout) {
-    this._timeout = timeout;
-    if (typeof hideTimeout === 'number')
-      this._hideTimeout = hideTimeout;
-    else
-      this._hideTimeout = timeout / 2;
+  setTimeout(showTimeout, hideTimeout) {
+    this._showTimeout = showTimeout;
+    this._hideTimeout = typeof hideTimeout === 'number' ? hideTimeout : showTimeout / 2;
   }
 
   /**
    * @param {boolean} hasPadding
    */
   setHasPadding(hasPadding) {
     this._hasPadding = hasPadding;
   }
 
   /**
@@ skipping 32 matching lines @@
    */
   _mouseMove(event) {
     // Pretend that nothing has happened.
     if (this._eventInScheduledContent(event))
       return;
 
     this._startHidePopoverTimer(this._hideTimeout);
     this._stopShowPopoverTimer();
     if (event.which && this._disableOnClick)
       return;
-    this._startShowPopoverTimer(event, this.isPopoverVisible() ? this._timeout * 0.6 : this._timeout);
+    this._startShowPopoverTimer(event, this.isPopoverVisible() ? this._showTimeout * 0.6 : this._showTimeout);
   }
 
   /**
    * @param {!Event} event
    */
   _popoverMouseMove(event) {
     this._stopHidePopoverTimer();
   }
 
   /**
@@ skipping 110 matching lines @@
       this._hidePopoverCallback = () => {
         if (request.hide)
           request.hide.call(null);
         popover.hide();
         delete UI.PopoverHelper._popoverHelper;
       };
     });
   }
 
   _stopHidePopoverTimer() {
-    if (!this._hidePopoverTimer)
+    if (!this._hidePopoverTimer || !this._hideTimeout)

[dgozman, 2017/04/17 23:16:13]

Why this change? It affects ElementsPanel and AnimationTimeline as well.

       return;
     clearTimeout(this._hidePopoverTimer);
     delete this._hidePopoverTimer;
 
     // We know that we reached the popup, but we might have moved over other elements.
     // Discard pending command.
     this._stopShowPopoverTimer();
   }
 };
 
 /** @typedef {{box: !AnchorBox, show:(function(!UI.GlassPane):!Promise<boolean>), hide:(function()|undefined)}} */
 UI.PopoverRequest;