Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: ash/shelf/shelf_tooltip_manager_unittest.cc

Issue 2825533003: mash: Prerequisites for removing ShelfDelegate. (Closed)
Patch Set: Expand CheckWindowAndItemPlacement comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shelf/shelf_application_menu_model_unittest.cc ('k') | ash/shelf/shelf_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_tooltip_manager_unittest.cc
diff --git a/ash/shelf/shelf_tooltip_manager_unittest.cc b/ash/shelf/shelf_tooltip_manager_unittest.cc
index 8dd94623f0887c6e667c672db362e63495fb35b3..089e998b37c6b9fca180b4d8984002fdd66434d4 100644
--- a/ash/shelf/shelf_tooltip_manager_unittest.cc
+++ b/ash/shelf/shelf_tooltip_manager_unittest.cc
@@ -12,7 +12,6 @@
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/test/shelf_view_test_api.h"
-#include "ash/test/test_shelf_item_delegate.h"
#include "base/memory/ptr_util.h"
#include "ui/events/event_constants.h"
#include "ui/events/test/event_generator.h"
@@ -88,9 +87,6 @@ TEST_F(ShelfTooltipManagerTest, DoNotShowForInvalidView) {
ShelfItem item;
item.type = TYPE_PINNED_APP;
const int index = model->Add(item);
- const ShelfID id = model->items()[index].id;
- model->SetShelfItemDelegate(id,
- base::MakeUnique<TestShelfItemDelegate>(nullptr));
// Note: There's no easy way to correlate shelf a model index/id to its view.
tooltip_manager_->ShowTooltipWithDelay(
shelf_view_->child_at(shelf_view_->child_count() - 1));
« no previous file with comments | « ash/shelf/shelf_application_menu_model_unittest.cc ('k') | ash/shelf/shelf_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698