Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2825523002: Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2… (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce ModulePendingScript (patchset #6 id:100001 of https://codereview.chromium.org/2815453006/ ) Reason for revert: Reason for revert: https://codereview.chromium.org/2653923008/ is suspected to cause CHECK() failure (crbug.com/711703) inside PendingScript's prefinalizer. BUG=711703 Original issue's description: > Introduce ModulePendingScript > > BUG=594639 > > Review-Url: https://codereview.chromium.org/2815453006 > Cr-Commit-Position: refs/heads/master@{#464627} > Committed: https://chromium.googlesource.com/chromium/src/+/2e5a5b8efccf655f183cc7ce0c59a88f77bb50f5 TBR=kouhei@chromium.org,yhirano@chromium.org,sigbjornf@opera.com,japhet@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594639 Review-Url: https://codereview.chromium.org/2816043005 Cr-Commit-Position: refs/heads/master@{#464765} (cherry picked from commit 80f482b929e1a00817069b15e78cc4473eb50c6f) Review-Url: https://codereview.chromium.org/2825523002 . Cr-Commit-Position: refs/branch-heads/3071@{#16} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/55e77d0d013c4aebd367ff67b61a113518141985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -189 lines) Patch
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Modulator.h View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ModulePendingScript.h View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/WebKit/Source/core/dom/ModulePendingScript.cpp View 1 chunk +0 lines, -82 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hiroshige
3 years, 8 months ago (2017-04-17 17:41:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
55e77d0d013c4aebd367ff67b61a113518141985.

Powered by Google App Engine
This is Rietveld 408576698