chrome/browser/resources/settings/printing_page/cloud_printers.html - Issue 2825493003: MD Settings: change outlinks to actually use <a>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/printing_page/cloud_printers.html

Issue 2825493003: MD Settings: change outlinks to actually use <a> (Closed)

Patch Set: replace more Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/appearance_page/appearance_page.js ('K') | « chrome/browser/resources/settings/people_page/sync_page.js ('k') | chrome/browser/resources/settings/printing_page/cloud_printers.js » ('j') | chrome/browser/resources/settings/privacy_page/privacy_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/printing_page/cloud_printers.html

diff --git a/chrome/browser/resources/settings/printing_page/cloud_printers.html b/chrome/browser/resources/settings/printing_page/cloud_printers.html

index d47403fc29784199a7995c08ce395ba54d1142c8..73ccacfda6c85d1a65c4bedb7d6e8c0ec4ced4cd 100644

--- a/chrome/browser/resources/settings/printing_page/cloud_printers.html

+++ b/chrome/browser/resources/settings/printing_page/cloud_printers.html

@@ -20,13 +20,14 @@

label="$i18n{printingNotificationsLabel}">

</settings-toggle-button>

</div>

- <div class="settings-box" on-tap="onManageTap_" actionable>

+ <a class="settings-box" actionable tabindex="-1" target="_blank"

+ href="$i18nRaw{devicesUrl}">

$i18n{printingManageCloudPrintDevices}

</div>

<button class="icon-external" is="paper-icon-button-light"

aria-label="$i18n{printingManageCloudPrintDevices}"></button>

- </div>

+ </a>

</template>

</dom-module>