chrome/browser/resources/settings/people_page/sync_browser_proxy.js - Issue 2825493003: MD Settings: change outlinks to actually use <a>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/people_page/sync_browser_proxy.js

Issue 2825493003: MD Settings: change outlinks to actually use <a> (Closed)

Patch Set: replace more Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/appearance_page/appearance_page.js ('K') | « chrome/browser/resources/settings/people_page/people_page.js ('k') | chrome/browser/resources/settings/people_page/sync_page.html » ('j') | chrome/browser/resources/settings/privacy_page/privacy_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/people_page/sync_browser_proxy.js

diff --git a/chrome/browser/resources/settings/people_page/sync_browser_proxy.js b/chrome/browser/resources/settings/people_page/sync_browser_proxy.js

index 1d332be06d7a4515a43a18cbf691e2a2ba50aa15..572dcb4f9c04bd9ee3d49f9f89f2bac1eba626f4 100644

--- a/chrome/browser/resources/settings/people_page/sync_browser_proxy.js

+++ b/chrome/browser/resources/settings/people_page/sync_browser_proxy.js

@@ -232,7 +232,6 @@ cr.define('settings', function() {

openActivityControlsUrl: function() {

chrome.metricsPrivate.recordUserAction(

'Signin_AccountSettings_GoogleActivityControlsClicked');

- window.open(loadTimeData.getString('activityControlsUrl'));

}

};