Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 2825493003: MD Settings: change outlinks to actually use <a> (Closed)
Patch Set: replace more, add target blank Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index b6e0dce6d89ef177ea554cb72e858f0a34ddb471..4c89ab133f9405a767f525c2d9beba397e0105d2 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -378,12 +378,12 @@
sub-option-secondary="$i18n{siteSettingsFlashAskBeforeSubtitle}">
</category-default-setting>
<if expr="chromeos">
- <div actionable class="settings-box"
- on-tap="onAdobeFlashStorageClicked_">
+ <a actionable class="settings-box" tabindex="-1" target="_blank"
+ href="https://www.macromedia.com/support/documentation/en/flashplayer/help/settings_manager07.html">
scottchen 2017/04/18 19:12:49 not sure what to do about 80-col here.
<div class="start">$i18n{adobeFlashStorage}</div>
<button class="icon-external" is="paper-icon-button-light"
aria-label="$i18n{adobeFlashStorage}"></button>
- </div>
+ </a>
</if>
<category-setting-exceptions
category="{{ContentSettingsTypes.PLUGINS}}">

Powered by Google App Engine
This is Rietveld 408576698