Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2296)

Unified Diff: chrome/browser/resources/settings/a11y_page/a11y_page.html

Issue 2825493003: MD Settings: change outlinks to actually use <a> (Closed)
Patch Set: replace more, add target blank Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/a11y_page/a11y_page.html
diff --git a/chrome/browser/resources/settings/a11y_page/a11y_page.html b/chrome/browser/resources/settings/a11y_page/a11y_page.html
index 9a26583b53ac6a07944b30e43ea1518412f74550..79352c22431e19e40973959bd4890e8d2932b44c 100644
--- a/chrome/browser/resources/settings/a11y_page/a11y_page.html
+++ b/chrome/browser/resources/settings/a11y_page/a11y_page.html
@@ -50,8 +50,9 @@
</if>
<if expr="not chromeos">
- <div class="settings-box first two-line" on-tap="onMoreFeaturesTap_"
- actionable>
+ <a class="settings-box first two-line" actionable tabindex="-1"
+ target="_blank"
+ href="https://chrome.google.com/webstore/category/collection/accessibility">
scottchen 2017/04/18 19:12:49 not sure what to do about 80-col here.
<div class="start">
$i18n{moreFeaturesLink}
<div class="secondary" id="moreFeaturesSecondary">
@@ -61,7 +62,7 @@
<button class="icon-external" is="paper-icon-button-light"
aria-label="$i18n{moreFeaturesLink}"
aria-describedby="moreFeaturesSecondary"></button>
- </div>
+ </a>
</if>
</template>

Powered by Google App Engine
This is Rietveld 408576698