Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3520)

Unified Diff: chrome/browser/resources/settings/search_page/search_page.html

Issue 2825493003: MD Settings: change outlinks to actually use <a> (Closed)
Patch Set: merge Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_page/search_page.html
diff --git a/chrome/browser/resources/settings/search_page/search_page.html b/chrome/browser/resources/settings/search_page/search_page.html
index f19514a35f9b635448916d5e9e76d69b9f481511..e87bb580d954c6fce24d4bd35256843ccb52ba46 100644
--- a/chrome/browser/resources/settings/search_page/search_page.html
+++ b/chrome/browser/resources/settings/search_page/search_page.html
@@ -106,8 +106,9 @@
</template>
<template is="dom-if" if="[[hotwordInfo_.historyEnabled]]">
- <div class="settings-box two-line continuation indented"
- on-tap="onManageAudioHistoryTap_" actionable>
+ <a class="settings-box two-line continuation indented inherit-color
+ no-outline" tabindex="-1" target="_blank"
+ href="$i18n{manageAudioHistoryUrl}">
<div class="start">
[[i18n('searchOkGoogleAudioHistoryLabel',
hotwordInfo_.userName)]]
@@ -115,11 +116,12 @@
$i18n{searchOkGoogleAudioHistorySubtext}
</div>
</div>
- <button class="icon-external" is="paper-icon-button-light"
+ <button actionable class="icon-external"
+ is="paper-icon-button-light"
aria-label$="[[i18n('searchOkGoogleAudioHistoryLabel',
hotwordInfo_.userName)]]"
aria-describedby="audioHistorySecondary"></button>
- </div>
+ </a>
</template>
</template>

Powered by Google App Engine
This is Rietveld 408576698