Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5503)

Unified Diff: chrome/browser/resources/settings/people_page/sync_page.html

Issue 2825493003: MD Settings: change outlinks to actually use <a> (Closed)
Patch Set: merge Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/sync_page.html
diff --git a/chrome/browser/resources/settings/people_page/sync_page.html b/chrome/browser/resources/settings/people_page/sync_page.html
index 3761fa52596513200a9853e92df85995256a41cf..32bf38d809db1bc39e7244e524a219ea85b969a5 100644
--- a/chrome/browser/resources/settings/people_page/sync_page.html
+++ b/chrome/browser/resources/settings/people_page/sync_page.html
@@ -249,7 +249,8 @@
</div>
</div>
- <div class="settings-box two-line" actionable
+ <a class="settings-box two-line inherit-color no-outline" tabindex="-1"
+ target="_blank" href="$i18n{activityControlsUrl}"
on-tap="onActivityControlsTap_">
<div class="start">
$i18n{personalizeGoogleServicesTitle}
@@ -258,17 +259,18 @@
</div>
</div>
<button class="icon-external" is="paper-icon-button-light"
- aria-label="$i18n{personalizeGoogleServicesTitle}"
+ actionable aria-label="$i18n{personalizeGoogleServicesTitle}"
aria-describedby="activityControlsSecondary"></button>
- </div>
+ </a>
- <div class="settings-box" actionable on-tap="onManageSyncedDataTap_">
+ <a class="settings-box inherit-color no-outline" tabindex="-1"
+ target="_blank" href="$i18n{syncDashboardUrl}">
<div class="start">
$i18n{manageSyncedDataTitle}
</div>
- <button class="icon-external" is="paper-icon-button-light"
+ <button class="icon-external" is="paper-icon-button-light" actionable
aria-label="$i18n{manageSyncedDataTitle}"></button>
- </div>
+ </a>
<div id="encryptionDescription" hidden="[[syncPrefs.passphraseRequired]]"
class="settings-box two-line single-column">

Powered by Google App Engine
This is Rietveld 408576698