MD Settings: change outlinks to actually use <a>

chrome/browser/resources/settings/privacy_page/privacy_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-privacy-page' is the settings page containing privacy and
  * security settings.
  */
 (function() {
@@ skipping 228 matching lines @@
     settings.navigateTo(settings.Route.CLEAR_BROWSER_DATA);
   },
 
   /** @private */
   onDialogClosed_: function() {
     settings.navigateToPreviousRoute();
     this.$.clearBrowsingDataTrigger.focus();
   },
 
   /** @private */
-  onHelpTap_: function() {

[dpapad, 2017/04/18 21:29:27]

Dead code?

[scottchen, 2017/04/18 22:41:51]

Yeah, privacy_page.html doesn't use onHelpTap_ anymore.
https://cs.chromium.org/search/?q=onHelpTap_+package:%5Echromium$&type=cs

-    window.open(
-        'https://support.google.com/chrome/?p=settings_manage_exceptions');
-  },
-
-  /** @private */
   onSberChange_: function() {
     var enabled = this.$.safeBrowsingExtendedReportingControl.checked;
     this.browserProxy_.setSafeBrowsingExtendedReportingEnabled(enabled);
   },
 
 // <if expr="_google_chrome and not chromeos">
   /** @private */
   onMetricsReportingChange_: function() {
     var enabled = this.$.metricsReportingControl.checked;
     this.browserProxy_.setMetricsReportingEnabled(enabled);
@@ skipping 53 matching lines @@
    * The sub-page title for the site or content settings.
    * @return {string}
    * @private
    */
   siteSettingsPageTitle_: function() {
     return loadTimeData.getBoolean('enableSiteSettings') ?
         loadTimeData.getString('siteSettings') :
         loadTimeData.getString('contentSettings');
   },
 
-// <if expr="chromeos">
-  /** @private */
-  onAdobeFlashStorageClicked_: function() {
-    window.open('https://www.macromedia.com/support/' +
-        'documentation/en/flashplayer/help/settings_manager07.html');
-  },
-// </if>
-
   /** @private */
   getProtectedContentLabel_: function(value) {
     return value ? this.i18n('siteSettingsProtectedContentEnable')
                  : this.i18n('siteSettingsBlocked');
   },
 
   /** @private */
   getProtectedContentIdentifiersLabel_: function(value) {
     return value ? this.i18n('siteSettingsProtectedContentEnableIdentifiers')
                  : this.i18n('siteSettingsBlocked');
   },
 });
 })();