chrome/browser/resources/settings/printing_page/cloud_printers.html - Issue 2825493003: MD Settings: change outlinks to actually use <a>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/printing_page/cloud_printers.html

Issue 2825493003: MD Settings: change outlinks to actually use <a> (Closed)

Patch Set: merge Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/people_page/sync_page.js ('k') | chrome/browser/resources/settings/printing_page/cloud_printers.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/polymer.html">	1 <link rel="import" href="chrome://resources/html/polymer.html">

2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">	2 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">

3 <link rel="import" href="../controls/settings_toggle_button.html">	3 <link rel="import" href="../controls/settings_toggle_button.html">

4 <link rel="import" href="../settings_shared_css.html">	4 <link rel="import" href="../settings_shared_css.html">

5	5

6 <dom-module id="settings-cloud-printers">	6 <dom-module id="settings-cloud-printers">

7 <template>	7 <template>

8 <style include="settings-shared"></style>	8 <style include="settings-shared"></style>

9 <div class="settings-box first">	9 <div class="settings-box first">

10 <span>	10 <span>

11 $i18n{printingCloudPrintLearnMoreLabel}	11 $i18n{printingCloudPrintLearnMoreLabel}

12 <a href="$i18n{printingCloudPrintLearnMoreUrl}" target="_blank">	12 <a href="$i18n{printingCloudPrintLearnMoreUrl}" target="_blank">

13 $i18n{learnMore}	13 $i18n{learnMore}

14 </a>	14 </a>

15 </span>	15 </span>

16 </div>	16 </div>

17 <div class="settings-box">	17 <div class="settings-box">

18 <settings-toggle-button class="start"	18 <settings-toggle-button class="start"

19 pref="{{prefs.local_discovery.notifications_enabled}}"	19 pref="{{prefs.local_discovery.notifications_enabled}}"

20 label="$i18n{printingNotificationsLabel}">	20 label="$i18n{printingNotificationsLabel}">

21 </settings-toggle-button>	21 </settings-toggle-button>

22 </div>	22 </div>

23 <div class="settings-box" on-tap="onManageTap_" actionable>	23 <a class="settings-box inherit-color no-outline" tabindex="-1"

	24 target="_blank" href="$i18n{devicesUrl}">

24 <div class="start">	25 <div class="start">

25 $i18n{printingManageCloudPrintDevices}	26 $i18n{printingManageCloudPrintDevices}

26 </div>	27 </div>

27 <button class="icon-external" is="paper-icon-button-light"	28 <button class="icon-external" is="paper-icon-button-light" actionable

28 aria-label="$i18n{printingManageCloudPrintDevices}"></button>	29 aria-label="$i18n{printingManageCloudPrintDevices}"></button>

29 </div>	30 </a>

30 </template>	31 </template>

31 <script src="cloud_printers.js"></script>	32 <script src="cloud_printers.js"></script>

32 </dom-module>	33 </dom-module>

OLD	NEW