MD Settings: change outlinks to actually use <a>

chrome/browser/resources/settings/appearance_page/appearance_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * This is the absolute difference maintained between standard and
  * fixed-width font sizes. http://crbug.com/91922.
  * @const @private {number}
  */
@@ skipping 76 matching lines @@
         3,
         4,
         5,
       ],
     },
 
     /** @private */
     themeSublabel_: String,
 
     /** @private */
+    themeUrl_: String,
+
+    /** @private */
     useSystemTheme_: {
       type: Boolean,
       value: false,  // Can only be true on Linux, but value exists everywhere.
     },
 
     /** @private {!Map<string, string>} */
     focusConfig_: {
       type: Object,
       value: function() {
         var map = new Map();
         map.set(
             settings.Route.FONTS.path,
             '#customize-fonts-subpage-trigger .subpage-arrow');
         return map;
       },
     },
   },
 
   /** @private {?settings.AppearanceBrowserProxy} */
   browserProxy_: null,
 
-  /** @private {string} */
-  themeUrl_: '',
-
   observers: [
     'defaultFontSizeChanged_(prefs.webkit.webprefs.default_font_size.value)',
     'themeChanged_(prefs.extensions.theme.id.value, useSystemTheme_)',
 
     // <if expr="is_linux and not chromeos">
     // NOTE: this pref only exists on Linux.
     'useSystemThemePrefChanged_(prefs.extensions.theme.use_system.value)',
     // </if>
   ],
 
@@ skipping 49 matching lines @@
    * @private
    */
   defaultFontSizeChanged_: function(value) {
     // This pref is handled separately in some extensions, but here it is tied
     // to default_font_size (to simplify the UI).
     this.set(
         'prefs.webkit.webprefs.default_fixed_font_size.value',
         value - SIZE_DIFFERENCE_FIXED_STANDARD_);
   },
 
-  /** @private */
-  onThemesTap_: function() {
-    window.open(this.themeUrl_ || loadTimeData.getString('themesGalleryUrl'));
+  /**
+   * URL for either current theme or the theme gallery.

[dschuyler, 2017/04/20 18:50:04]

@return {string}

[scottchen, 2017/04/20 21:48:34]

Done. Sorry, missed it the first time you said it.

+   * @private
+   */
+  getThemeHref_: function() {
+    return this.themeUrl_ || loadTimeData.getString('themesGalleryUrl');
   },
 
   // <if expr="chromeos">
   /**
    * ChromeOS only.
    * @private
    */
   openWallpaperManager_: function() {
     this.browserProxy_.openWallpaperManager();
   },
@@ skipping 97 matching lines @@
    * @see content::ZoomValuesEqual().
    * @param {number} zoom1
    * @param {number} zoom2
    * @return {boolean}
    * @private
    */
   zoomValuesEqual_: function(zoom1, zoom2) {
     return Math.abs(zoom1 - zoom2) <= 0.001;
   },
 });