Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html

Issue 2825393004: bluetooth: Check the order of event and promise resolution for readValue (Closed)
Patch Set: Address moar feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html b/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html
index 3f1a9a6ea396f7611079cb8f0fdc38dc931cc41e..e95a09bd0f4808b22bcf0af32996ceb4a2e66100 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html
@@ -12,19 +12,13 @@ promise_test(() => {
.then(gattServer => gattServer.getPrimaryService('heart_rate'))
.then(service => service.getCharacteristic('body_sensor_location'))
.then(characteristic => {
- return assert_event_fires_after_promise(characteristic,
- 'readValue',
- 'characteristicvaluechanged',
- 1 /* attach 1 listener */,
- true /* ignore_event_promise_order */);
+ return assert_promise_resolves_after_event(characteristic,
+ 'readValue',
+ 'characteristicvaluechanged');
}).then(results => {
let read_value = results[0].buffer;
let event_value = results[1].buffer;
- // TODO(ortuno): The DataView used to resolve the promise
- // should be the same DataView as the one saved in the
- // characteristic.
- // http://crbug.com/543347
- // assert_equals(event.target.value, value);
+ assert_equals(event_value, read_value);
assert_array_equals(event_value, read_value);
});
}, 'Reading a characteristic should fire an event.');

Powered by Google App Engine
This is Rietveld 408576698