third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html - Issue 2825393004: bluetooth: Check the order of event and promise resolution for readValue

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html

Issue 2825393004: bluetooth: Check the order of event and promise resolution for readValue (Closed)

Patch Set: Address moar feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-multiple-event-listeners.html ('k') | third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/add-multiple-event-listeners.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(() => {	7 promise_test(() => {

8 return setBluetoothFakeAdapter('HeartRateAdapter')	8 return setBluetoothFakeAdapter('HeartRateAdapter')

9 .then(() => requestDeviceWithKeyDown({	9 .then(() => requestDeviceWithKeyDown({

10 filters: [{services: ['heart_rate']}]}))	10 filters: [{services: ['heart_rate']}]}))

11 .then(device => device.gatt.connect())	11 .then(device => device.gatt.connect())

12 .then(gattServer => gattServer.getPrimaryService('heart_rate'))	12 .then(gattServer => gattServer.getPrimaryService('heart_rate'))

13 .then(service => service.getCharacteristic('heart_rate_measurement'))	13 .then(service => service.getCharacteristic('heart_rate_measurement'))

14 .then(characteristic => {	14 .then(characteristic => {

15 return assert_event_fires_after_promise(	15 return assert_promise_resolves_before_event(

16 characteristic, 'startNotifications', 'characteristicvaluechanged',	16 characteristic, 'startNotifications', 'characteristicvaluechanged')

17 1 /* attach 1 listener /, false / ignore_event_promise_order */)

18 .then(() => characteristic.stopNotifications())	17 .then(() => characteristic.stopNotifications())

19 .then(() => assert_no_events(characteristic,	18 .then(() => assert_no_events(characteristic,

20 'characteristicvaluechanged'));	19 'characteristicvaluechanged'));

21 });	20 });

22 }, 'Starting notifications should fire an event and we should get no events ' +	21 }, 'Starting notifications should fire an event and we should get no events ' +

23 'after notifications are stopped.');	22 'after notifications are stopped.');

24 </script>	23 </script>

OLD	NEW