Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: ash/system/palette/palette_utils.h

Issue 2825383003: Fix stylus tools palette. (Closed)
Patch Set: Load palette_tray all the time. Only check when show it Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/palette/palette_tray.cc ('k') | ash/system/palette/palette_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/palette/palette_utils.h
diff --git a/ash/system/palette/palette_utils.h b/ash/system/palette/palette_utils.h
index 1137f90ef9eec461662498851c188bf0e6bee427..96ca75c0927f43fbda4448228d16fdc2c438e01b 100644
--- a/ash/system/palette/palette_utils.h
+++ b/ash/system/palette/palette_utils.h
@@ -14,14 +14,15 @@ class Point;
namespace ash {
namespace palette_utils {
-// Returns true if there is a stylus input device on the internal display. This
-// will return false even if there is a stylus input device until hardware
-// probing is complete (see ui::InputDeviceEventObserver).
+// Returns true if there is a stylus input device on the internal display.
jdufault 2017/04/26 18:50:43 Revert this change?
wutao 2017/04/26 22:01:50 Done.
ASH_EXPORT bool HasStylusInput();
jdufault 2017/04/26 18:50:43 Does this still need to be in the header?
wutao 2017/04/26 22:01:50 Yes. There are multiple sites calling this.
// Returns true if the palette should be shown on every display.
ASH_EXPORT bool IsPaletteEnabledOnEveryDisplay();
+// Returns true if we should show palette.
jdufault 2017/04/26 18:50:42 Can you be a bit more detailed in this comment, ie
wutao 2017/04/26 22:01:50 Done.
+ASH_EXPORT bool ShouldShowPalette();
+
// Returns true if either the palette icon or the palette widget contain the
// given point (in screen space).
ASH_EXPORT bool PaletteContainsPointInScreen(const gfx::Point& point);
« no previous file with comments | « ash/system/palette/palette_tray.cc ('k') | ash/system/palette/palette_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698