Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl

Issue 2825363002: Revert of DCHECK for execution context being unsuspended during v8 bindings callback. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
index e3086434b4f8ff97ef1aec9db449c285ec215bdd..c417aaa13010a71a7cf191e88763c26a058ce605 100644
--- a/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
@@ -26,8 +26,8 @@
if method.idl_type == 'boolean' else 'return' %}{# void #}
ExecutionContext* executionContext =
ExecutionContext::From(m_scriptState.Get());
- DCHECK(!executionContext->IsContextSuspended());
- if (!executionContext || executionContext->IsContextDestroyed())
+ if (!executionContext || executionContext->IsContextSuspended() ||
+ executionContext->IsContextDestroyed())
{{return_default}};
if (!m_scriptState->ContextIsValid())
{{return_default}};
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698