Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: third_party/WebKit/Source/core/html/HTMLElement.cpp

Issue 2825343003: Clean compositing inputs for location APIs for sticky-affected elements. (Closed)
Patch Set: First pass addressing reviewer comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLElement.cpp b/third_party/WebKit/Source/core/html/HTMLElement.cpp
index d0d4c083394be934a738e88061b72771157aac13..ce8a1f425c4935733a30ea92244ba339260c479b 100644
--- a/third_party/WebKit/Source/core/html/HTMLElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLElement.cpp
@@ -1141,6 +1141,7 @@ const AtomicString& HTMLElement::EventParameterName() {
}
int HTMLElement::offsetLeftForBinding() {
+ GetDocument().EnsureLifecycleValidForLocationAPIsForNode(this);
Element* offset_parent = unclosedOffsetParent();
if (LayoutBoxModelObject* layout_object = GetLayoutBoxModelObject())
return AdjustLayoutUnitForAbsoluteZoom(
@@ -1151,6 +1152,7 @@ int HTMLElement::offsetLeftForBinding() {
}
int HTMLElement::offsetTopForBinding() {
+ GetDocument().EnsureLifecycleValidForLocationAPIsForNode(this);
Element* offset_parent = unclosedOffsetParent();
if (LayoutBoxModelObject* layout_object = GetLayoutBoxModelObject())
return AdjustLayoutUnitForAbsoluteZoom(
@@ -1161,6 +1163,7 @@ int HTMLElement::offsetTopForBinding() {
}
int HTMLElement::offsetWidthForBinding() {
+ GetDocument().EnsureLifecycleValidForLocationAPIsForNode(this);
Element* offset_parent = unclosedOffsetParent();
if (LayoutBoxModelObject* layout_object = GetLayoutBoxModelObject())
return AdjustLayoutUnitForAbsoluteZoom(
@@ -1173,6 +1176,7 @@ int HTMLElement::offsetWidthForBinding() {
DISABLE_CFI_PERF
int HTMLElement::offsetHeightForBinding() {
+ GetDocument().EnsureLifecycleValidForLocationAPIsForNode(this);
Element* offset_parent = unclosedOffsetParent();
if (LayoutBoxModelObject* layout_object = GetLayoutBoxModelObject())
return AdjustLayoutUnitForAbsoluteZoom(

Powered by Google App Engine
This is Rietveld 408576698