Clean compositing inputs for location APIs for sticky-affected elements.

third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc.
  * All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
@@ skipping 948 matching lines @@
       svg_style.SetBaselineShift(BS_SUB);
       return;
     case CSSValueSuper:
       svg_style.SetBaselineShift(BS_SUPER);
       return;
     default:
       NOTREACHED();
   }
 }
 
+void StyleBuilderFunctions::applyInitialCSSPropertyPosition(
+    StyleResolverState& state) {
+  state.Style()->SetPosition(ComputedStyle::InitialPosition());
+  state.Style()->SetIsInStickySubtree(state.ParentStyle()->IsInStickySubtree());
+}
+
 void StyleBuilderFunctions::applyInheritCSSPropertyPosition(
     StyleResolverState& state) {
   if (!state.ParentNode()->IsDocumentNode())
     state.Style()->SetPosition(state.ParentStyle()->GetPosition());
+  state.Style()->SetIsInStickySubtree(state.ParentStyle()->IsInStickySubtree());

[flackr, 2017/04/27 15:50:02]

I patched this in and I only see
StyleBuilderFunctions::applyValueCSSPropertyPosition being called, and only on
the elements which have had position explicitly set on them (i.e. #a and #b on
http://output.jsbin.com/gamisi/quiet). Are you sure it's inheriting correctly?

[smcgruer, 2017/04/27 16:05:28]

Did you set position to inherit? That is the case where this method would be
called.

[flackr, 2017/04/27 17:17:01]

But if the methods don't get called automatically on the descendants then won't
we have the same bug if you ask for the offset of a descendant of a sticky
element? (i.e. we won't have updated the IsInStickySubtree property to know
that).

[flackr, 2017/04/27 17:20:53]

Looks like it doesn't get inherited to the descendant - see
http://output.jsbin.com/gamisi/quiet

[flackr, 2017/04/27 19:20:51]

Nevermind I was mistakenly assuming the offsetTop of the child should change,
and you do have a test for the child in ElementTest.cpp. Can you add a couple
tests to make sure adding and removing isInStickySubtree is updated correctly
for the correct elements?

[smcgruer, 2017/04/28 18:20:37]

Done.

+}
+
+void StyleBuilderFunctions::applyValueCSSPropertyPosition(
+    StyleResolverState& state,
+    const CSSValue& value) {
+  EPosition position = ToCSSIdentifierValue(value).ConvertTo<EPosition>();
+  state.Style()->SetPosition(position);
+  state.Style()->SetIsInStickySubtree(position == EPosition::kSticky ||
+                                      state.ParentStyle()->IsInStickySubtree());
 }
 
 void StyleBuilderFunctions::applyInitialCSSPropertyCaretColor(
     StyleResolverState& state) {
   StyleAutoColor color = StyleAutoColor::AutoColor();
   if (state.ApplyPropertyToRegularStyle())
     state.Style()->SetCaretColor(color);
   if (state.ApplyPropertyToVisitedLinkStyle())
     state.Style()->SetVisitedLinkCaretColor(color);
 }
@@ skipping 14 matching lines @@
     state.Style()->SetCaretColor(
         StyleBuilderConverter::ConvertStyleAutoColor(state, value));
   }
   if (state.ApplyPropertyToVisitedLinkStyle()) {
     state.Style()->SetVisitedLinkCaretColor(
         StyleBuilderConverter::ConvertStyleAutoColor(state, value, true));
   }
 }
 
 }  // namespace blink