Clean compositing inputs for location APIs for sticky-affected elements.

third_party/WebKit/Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
  * rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
@@ skipping 2328 matching lines @@
 
   return EnsureStyleResolver().StyleForElement(element, parent_style,
                                                layout_parent_style);
 }
 
 PassRefPtr<ComputedStyle> Document::StyleForPage(int page_index) {
   UpdateDistribution();
   return EnsureStyleResolver().StyleForPage(page_index);
 }
 
+void Document::EnsureLifecycleValidForLocationAPIsForNode(const Node* node) {
+  DCHECK(node);
+  if (!node->InActiveDocument())
+    return;
+
+  // For all nodes we must have up-to-date style and have performed layout to do
+  // any location-based calculation.
+  UpdateStyleAndLayoutIgnorePendingStylesheets();
+
+  // The location of elements that are position: sticky is not known until
+  // compositing inputs are cleaned. Therefore, for any elements that are either
+  // sticky or are in a sticky sub-tree (e.g. are affected by a sticky element),
+  // we need to also clean compositing inputs.
+  if (UNLIKELY(View() && node->GetLayoutObject() &&

[fs, 2017/05/01 21:19:34]

Nit: Did you see any effect of the UNLIKELY here? Considering that only the last
part of the expression is "unlikely", and there's no else it seems it becomes a
matter of some I$ misses (or not.) (And AFAIU we shouldn't be sprinkling
UNLIKELY unless they matter - and they don't even do anything on Windows last I
checked...)

[smcgruer, 2017/05/02 15:25:41]

I did not, it was mostly speculative. Removed.

+               node->GetLayoutObject()->Style()->IsInStickySubtree())) {

[fs, 2017/05/01 21:19:34]

Nit: StyleRef().

[smcgruer, 2017/05/02 15:25:41]

Done.

+    if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+      // In SPv2, compositing inputs are cleaned as part of PrePaint.
+      View()->UpdateAllLifecyclePhasesExceptPaint();
+    } else {
+      View()->UpdateLifecycleToCompositingInputsClean();
+    }
+  }
+}
+
 bool Document::IsPageBoxVisible(int page_index) {
   return StyleForPage(page_index)->Visibility() !=
          EVisibility::kHidden;  // display property doesn't apply to @page.
 }
 
 void Document::PageSizeAndMarginsInPixels(int page_index,
                                           DoubleSize& page_size,
                                           int& margin_top,
                                           int& margin_right,
                                           int& margin_bottom,
@@ skipping 4362 matching lines @@
 }
 
 void showLiveDocumentInstances() {
   WeakDocumentSet& set = liveDocumentSet();
   fprintf(stderr, "There are %u documents currently alive:\n", set.size());
   for (blink::Document* document : set)
     fprintf(stderr, "- Document %p URL: %s\n", document,
             document->Url().GetString().Utf8().data());
 }
 #endif