Clean compositing inputs for location APIs for sticky-affected elements.

third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc.
  * All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
@@ skipping 948 matching lines @@
       svg_style.SetBaselineShift(BS_SUB);
       return;
     case CSSValueSuper:
       svg_style.SetBaselineShift(BS_SUPER);
       return;
     default:
       NOTREACHED();
   }
 }
 
+void StyleBuilderFunctions::applyInitialCSSPropertyPosition(
+    StyleResolverState& state) {
+  state.Style()->SetPosition(ComputedStyle::InitialPosition());
+  state.Style()->SetIsInStickySubtree(state.ParentStyle()->IsInStickySubtree());

[fs, 2017/04/29 09:59:06]

Do you even need this? Your bit should essentially be "Inherited: yes" (by
regular CSS spec parlance), so this bit would be updated by
ComputedStyle::InheritFrom regardless. (Make test if unsure.)

[smcgruer, 2017/05/01 20:15:15]

Done.

+}
+
 void StyleBuilderFunctions::applyInheritCSSPropertyPosition(
     StyleResolverState& state) {
   if (!state.ParentNode()->IsDocumentNode())
     state.Style()->SetPosition(state.ParentStyle()->GetPosition());
+  state.Style()->SetIsInStickySubtree(state.ParentStyle()->IsInStickySubtree());

[fs, 2017/04/29 09:59:06]

Ditto.

[smcgruer, 2017/05/01 20:15:15]

Done.

+}
+
+void StyleBuilderFunctions::applyValueCSSPropertyPosition(
+    StyleResolverState& state,
+    const CSSValue& value) {
+  EPosition position = ToCSSIdentifierValue(value).ConvertTo<EPosition>();
+  state.Style()->SetPosition(position);
+  state.Style()->SetIsInStickySubtree(position == EPosition::kSticky ||

[fs, 2017/04/29 12:10:31]

Thinking about it some more, maybe this should rather go in StyleAdjuster (since
that can override/change 'position', and you want to reduce the pessimism in
this flag much as possible I think.)

[smcgruer, 2017/05/01 20:15:15]

Done. Based on my tests it appears to work, so I assume StyleAdjuster is called
recursively if a parent style changes?

[fs, 2017/05/01 21:19:33]

Yes, since the flag is part of (rare) inherited, any difference to it should
cause a change (to 'position' essentially) to trigger recalc for the subtree.
CompustedStyle::StylePropagationDiff and NonIndependentInheritedEqual being the
key ingredients I believe. (Naturally this might also be a cause of alarm/new
perf differences...)

+                                      state.ParentStyle()->IsInStickySubtree());
 }
 
 void StyleBuilderFunctions::applyInitialCSSPropertyCaretColor(
     StyleResolverState& state) {
   StyleAutoColor color = StyleAutoColor::AutoColor();
   if (state.ApplyPropertyToRegularStyle())
     state.Style()->SetCaretColor(color);
   if (state.ApplyPropertyToVisitedLinkStyle())
     state.Style()->SetVisitedLinkCaretColor(color);
 }
@@ skipping 14 matching lines @@
     state.Style()->SetCaretColor(
         StyleBuilderConverter::ConvertStyleAutoColor(state, value));
   }
   if (state.ApplyPropertyToVisitedLinkStyle()) {
     state.Style()->SetVisitedLinkCaretColor(
         StyleBuilderConverter::ConvertStyleAutoColor(state, value, true));
   }
 }
 
 }  // namespace blink