Clean compositing inputs for location APIs for sticky-affected elements.

third_party/WebKit/Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
  * All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
@@ skipping 413 matching lines @@
     return attribute->Value();
   return g_null_atom;
 }
 
 AtomicString Element::LowercaseIfNecessary(const AtomicString& name) const {
   return IsHTMLElement() && GetDocument().IsHTMLDocument() ? name.LowerASCII()
                                                            : name;
 }
 
 void Element::scrollIntoView(bool align_to_top) {
-  GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  EnsureLifecycleValidForLocationAPIs();
 
   if (!GetLayoutObject())
     return;
 
   bool make_visible_in_visual_viewport =
       !GetDocument().GetPage()->GetSettings().GetInertVisualViewport();
 
   LayoutRect bounds = BoundingBox();
   // Align to the top / bottom and to the closest edge.
   if (align_to_top)
     GetLayoutObject()->ScrollRectToVisible(
         bounds, ScrollAlignment::kAlignToEdgeIfNeeded,
         ScrollAlignment::kAlignTopAlways, kProgrammaticScroll,
         make_visible_in_visual_viewport);
   else
     GetLayoutObject()->ScrollRectToVisible(
         bounds, ScrollAlignment::kAlignToEdgeIfNeeded,
         ScrollAlignment::kAlignBottomAlways, kProgrammaticScroll,
         make_visible_in_visual_viewport);
 
   GetDocument().SetSequentialFocusNavigationStartingPoint(this);
 }
 
 void Element::scrollIntoViewIfNeeded(bool center_if_needed) {
-  GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  EnsureLifecycleValidForLocationAPIs();
 
   if (!GetLayoutObject())
     return;
 
   bool make_visible_in_visual_viewport =
       !GetDocument().GetPage()->GetSettings().GetInertVisualViewport();
 
   LayoutRect bounds = BoundingBox();
   if (center_if_needed)
     GetLayoutObject()->ScrollRectToVisible(
@@ skipping 166 matching lines @@
     callback->handleEvent(&scroll_state);
   if (callback->NativeScrollBehavior() !=
       WebNativeScrollBehavior::kDisableNativeScroll)
     NativeApplyScroll(scroll_state);
   if (callback->NativeScrollBehavior() ==
       WebNativeScrollBehavior::kPerformAfterNativeScroll)
     callback->handleEvent(&scroll_state);
 }
 
 int Element::OffsetLeft() {
-  GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  EnsureLifecycleValidForLocationAPIs();
   if (LayoutBoxModelObject* layout_object = GetLayoutBoxModelObject())
     return AdjustLayoutUnitForAbsoluteZoom(
                LayoutUnit(
                    layout_object->PixelSnappedOffsetLeft(OffsetParent())),
                layout_object->StyleRef())
         .Round();
   return 0;
 }
 
 int Element::OffsetTop() {
-  GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  EnsureLifecycleValidForLocationAPIs();
   if (LayoutBoxModelObject* layout_object = GetLayoutBoxModelObject())
     return AdjustLayoutUnitForAbsoluteZoom(
                LayoutUnit(layout_object->PixelSnappedOffsetTop(OffsetParent())),
                layout_object->StyleRef())
         .Round();
   return 0;
 }
 
 int Element::OffsetWidth() {
   GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
@@ skipping 457 matching lines @@
   IntSize viewport_size = GetDocument().GetPage()->GetVisualViewport().Size();
   IntRect rect(0, 0, viewport_size.Width(), viewport_size.Height());
   // We don't use absoluteBoundingBoxRect() because it can return an IntRect
   // larger the actual size by 1px. crbug.com/470503
   rect.Intersect(GetDocument().View()->ContentsToViewport(
       RoundedIntRect(GetLayoutObject()->AbsoluteBoundingBoxFloatRect())));
   return rect;
 }
 
 void Element::ClientQuads(Vector<FloatQuad>& quads) {
-  GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheetsForNode(this);
+  EnsureLifecycleValidForLocationAPIs();
 
   LayoutObject* element_layout_object = GetLayoutObject();
   if (!element_layout_object)
     return;
 
   if (IsSVGElement() && !element_layout_object->IsSVGRoot()) {
     // Get the bounding rectangle from the SVG model.
     if (ToSVGElement(this)->IsSVGGraphicsElement())
       quads.push_back(element_layout_object->LocalToAbsoluteQuad(
           element_layout_object->ObjectBoundingBox()));
@@ skipping 3175 matching lines @@
   if (!activity_logger)
     return;
   Vector<String, 4> argv;
   argv.push_back(element);
   argv.push_back(params.name.ToString());
   argv.push_back(params.old_value);
   argv.push_back(params.new_value);
   activity_logger->LogEvent("blinkSetAttribute", argv.size(), argv.Data());
 }
 
+void Element::EnsureLifecycleValidForLocationAPIs() {
+  if (!InActiveDocument())
+    return;
+
+  GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();
+
+  FrameView* view = GetDocument().View();
+  LayoutObject* element_layout_object = GetLayoutObject();
+  if (UNLIKELY(view && element_layout_object &&
+               element_layout_object->EnclosingBoxModelObject() &&
+               element_layout_object->EnclosingBoxModelObject()
+                   ->IsInStickySubtree())) {
+    view->UpdateLifecycleToCompositingInputsClean();

[chrishtr, 2017/04/20 17:40:34]

Add a comment explaining why this is needed.

[smcgruer, 2017/04/26 14:37:06]

Done.

+  }
+}
+
 DEFINE_TRACE(Element) {
   if (HasRareData())
     visitor->Trace(GetElementRareData());
   visitor->Trace(element_data_);
   ContainerNode::Trace(visitor);
 }
 
 DEFINE_TRACE_WRAPPERS(Element) {
   if (HasRareData()) {
     visitor->TraceWrappers(GetElementRareData());
   }
   ContainerNode::TraceWrappers(visitor);
 }
 
 }  // namespace blink