Issue 282533002: ServiceWorker: Clean up ServiceWorkerDatabaseTest

Issue 282533002: ServiceWorker: Clean up ServiceWorkerDatabaseTest (Closed)

Created:
6 years, 7 months ago by nhiroki

Modified:
6 years, 7 months ago

Reviewers:
kinuko

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ServiceWorker: Clean up ServiceWorkerDatabaseTest Clean up ServiceWorkerDatabaseTest using helper functions. Mechanical changes only. BUG=n/a TEST=content_unittests --gtest_filter=ServiceWorkerDatabaseTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269770

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -72 lines)			Patch
	M	content/browser/service_worker/service_worker_database_unittest.cc	View	1	16 chunks	+72 lines, -72 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kinuko

lgtm https://codereview.chromium.org/282533002/diff/1/content/browser/service_worker/service_worker_database_unittest.cc File content/browser/service_worker/service_worker_database_unittest.cc (right): https://codereview.chromium.org/282533002/diff/1/content/browser/service_worker/service_worker_database_unittest.cc#newcode268 content/browser/service_worker/service_worker_database_unittest.cc:268: data1.script = URL(origin2, "/script1.js"); origin1 ?

6 years, 7 months ago (2014-05-12 10:16:28 UTC) #2

nhiroki

Thank you! https://codereview.chromium.org/282533002/diff/1/content/browser/service_worker/service_worker_database_unittest.cc File content/browser/service_worker/service_worker_database_unittest.cc (right): https://codereview.chromium.org/282533002/diff/1/content/browser/service_worker/service_worker_database_unittest.cc#newcode268 content/browser/service_worker/service_worker_database_unittest.cc:268: data1.script = URL(origin2, "/script1.js"); On 2014/05/12 10:16:29, ...

6 years, 7 months ago (2014-05-12 10:22:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/282533002/20001

6 years, 7 months ago (2014-05-12 10:23:14 UTC) #5

Message was sent while issue was closed.

Change committed as 269770

Expand Messages | Collapse Messages