Use resolveIsolatedEntries in the separated new Gallery.app.

Use resolveIsolatedEntries in the separated new Gallery.app.

The API is added crrev.com/270720.

BUG=358698
TEST=run the new Gallery.app.
R=mtomasz@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270960

[hirono, 2014-05-16 03:09:48]

PTAL the CL? Thank you!

[mtomasz, 2014-05-16 03:29:20]

lgtm with nits

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/background.js (right):

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/background.js:56: var backgroundComponentPromise =
BackgroundComponents.load();
nit: backgroundComponentPromise -> backgroundComponentsPromise

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/background.js:100: // The entries in launchData is
stored in the isolated file system.
nit: is -> are

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/gallery.js (right):

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery.js:894: var backgroundComponent = args[0];
nit: backgroundComponents?

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/image_lo...
File ui/file_manager/image_loader/image_loader.js (right):

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/image_lo...
ui/file_manager/image_loader/image_loader.js:80:
'nlkncpkkdoccmpiclbokaimcnedabhhm',  // Gallery extension id.
nit: Remove trailing coma.

[hirono, 2014-05-16 04:12:42]

The CQ bit was checked by hirono@chromium.org

[hirono, 2014-05-16 04:12:48]

Thank you!

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/background.js (right):

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/background.js:56: var backgroundComponentPromise =
BackgroundComponents.load();
On 2014/05/16 03:29:21, mtomasz wrote:
> nit: backgroundComponentPromise -> backgroundComponentsPromise

Done.

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/background.js:100: // The entries in launchData is
stored in the isolated file system.
On 2014/05/16 03:29:21, mtomasz wrote:
> nit: is -> are

Done.

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/gallery/...
File ui/file_manager/gallery/js/gallery.js (right):

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/gallery/...
ui/file_manager/gallery/js/gallery.js:894: var backgroundComponent = args[0];
On 2014/05/16 03:29:21, mtomasz wrote:
> nit: backgroundComponents?

Done.

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/image_lo...
File ui/file_manager/image_loader/image_loader.js (right):

https://codereview.chromium.org/282523002/diff/40001/ui/file_manager/image_lo...
ui/file_manager/image_loader/image_loader.js:80:
'nlkncpkkdoccmpiclbokaimcnedabhhm',  // Gallery extension id.
On 2014/05/16 03:29:21, mtomasz wrote:
> nit: Remove trailing coma.

Done.

[commit-bot: I haz the power, 2014-05-16 04:13:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/282523002/60001

[commit-bot: I haz the power, 2014-05-16 07:54:39]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[hirono, 2014-05-16 08:05:26]

Committed patchset #2 manually as r270960 (presubmit successful).