chrome/browser/resources/settings/basic_page/basic_page.js - Issue 2825203003: MD Settings: Remove subpage animation when landing directly on it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 2825203003: MD Settings: Remove subpage animation when landing directly on it. (Closed)

Patch Set: feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/basic_page/basic_page.js

diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js

index d360e891f428705bfcc79d468745f7fb91989688..426a9118ae51a02190227ce5a7d0983c72c2b182 100644

--- a/chrome/browser/resources/settings/basic_page/basic_page.js

+++ b/chrome/browser/resources/settings/basic_page/basic_page.js

@@ -67,6 +67,11 @@ Polymer({

/** @private {!settings.Route|undefined} */

currentRoute_: Object,

+ shouldHideContainer: {

michaelpg 2017/04/27 20:00:20 this should be added by the behavior - is there a

scottchen 2017/05/01 19:25:06 Looks like I don't need it.

+ type: Boolean,

+ notify: true,

+ }

listeners: {